Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6588] write_stdout and json_format are boolean #7199

Merged
merged 1 commit into from
Jan 22, 2020
Merged

[AIRFLOW-6588] write_stdout and json_format are boolean #7199

merged 1 commit into from
Jan 22, 2020

Conversation

pingzh
Copy link
Contributor

@pingzh pingzh commented Jan 18, 2020

as you can see in the https://github.com/apache/airflow/blob/master/airflow/utils/log/es_task_handler.py#L221
https://github.com/apache/airflow/blob/master/airflow/utils/log/es_task_handler.py#L210

Those args have to be boolean


Issue link: AIRFLOW-6588

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk
Copy link
Member

potiuk commented Jan 18, 2020

Some static checks are failing :(

@kaxil
Copy link
Member

kaxil commented Jan 20, 2020

You will have to update the following line too:

ELASTIC_REMOTE_HANDLERS: Dict[str, Dict[str, str]] = {

@pingzh
Copy link
Contributor Author

pingzh commented Jan 20, 2020

Updated

@codecov-io
Copy link

Codecov Report

Merging #7199 into master will decrease coverage by 0.17%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7199      +/-   ##
==========================================
- Coverage   85.41%   85.23%   -0.18%     
==========================================
  Files         753      758       +5     
  Lines       39685    39932     +247     
==========================================
+ Hits        33898    34038     +140     
- Misses       5787     5894     +107
Impacted Files Coverage Δ
airflow/config_templates/airflow_local_settings.py 71.73% <0%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 76.47% <0%> (-21.18%) ⬇️
airflow/providers/amazon/aws/sensors/emr_base.py 91.66% <0%> (-8.34%) ⬇️
airflow/api/client/local_client.py 92% <0%> (-8%) ⬇️
airflow/api/client/api_client.py 63.15% <0%> (-1.55%) ⬇️
airflow/gcp/hooks/dataflow.py 88.37% <0%> (-0.92%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5abce47...ba35b8e. Read the comment docs.

@KevinYang21 KevinYang21 merged commit 21a4651 into apache:master Jan 22, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil pushed a commit that referenced this pull request Mar 17, 2020
kaxil pushed a commit that referenced this pull request Mar 19, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants