-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6588] write_stdout and json_format are boolean #7199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some static checks are failing :( |
You will have to update the following line too:
|
Updated |
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #7199 +/- ##
==========================================
- Coverage 85.41% 85.23% -0.18%
==========================================
Files 753 758 +5
Lines 39685 39932 +247
==========================================
+ Hits 33898 34038 +140
- Misses 5787 5894 +107
Continue to review full report at Codecov.
|
KevinYang21
approved these changes
Jan 22, 2020
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 19, 2020
cherry-picked from 21a4651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as you can see in the https://github.com/apache/airflow/blob/master/airflow/utils/log/es_task_handler.py#L221
https://github.com/apache/airflow/blob/master/airflow/utils/log/es_task_handler.py#L210
Those args have to be boolean
Issue link: AIRFLOW-6588
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.