Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXXX] Add rebase info to contributing #7201

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 18, 2020


Issue link: Document only change, no JIRA issue

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @potiuk 👍 - I think this is really useful.

@potiuk
Copy link
Member Author

potiuk commented Jan 18, 2020

Thanks @efedotova ! Love the clarifications. I will separate those changes to separate commit as those are related to some earlier changes.

@potiuk potiuk force-pushed the AIRFLOW-XXXX-add-rebase-info-to-contributing branch from e30d69b to c440afb Compare January 18, 2020 20:04
@potiuk potiuk merged commit dfd0329 into apache:master Jan 18, 2020
potiuk added a commit that referenced this pull request Jan 21, 2020
kaxil pushed a commit that referenced this pull request Jan 22, 2020
kaxil pushed a commit that referenced this pull request Jan 23, 2020
potiuk added a commit that referenced this pull request Jan 26, 2020
kaxil pushed a commit that referenced this pull request Jan 26, 2020
kaxil pushed a commit that referenced this pull request Feb 3, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants