Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6589] BAT tests run in pre-commit on bash script changes #7203

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 18, 2020

The previous configuration did not work as intended.


Issue link: AIRFLOW-6589

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@codecov-io
Copy link

Codecov Report

Merging #7203 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7203      +/-   ##
==========================================
- Coverage   85.41%   85.41%   -0.01%     
==========================================
  Files         753      753              
  Lines       39689    39709      +20     
==========================================
+ Hits        33901    33917      +16     
- Misses       5788     5792       +4
Impacted Files Coverage Δ
airflow/providers/amazon/aws/sensors/emr_base.py 91.66% <0%> (-8.34%) ⬇️
airflow/jobs/backfill_job.py 91.59% <0%> (-0.29%) ⬇️
airflow/providers/amazon/aws/sensors/emr_step.py 100% <0%> (ø) ⬆️
...rflow/providers/amazon/aws/sensors/emr_job_flow.py 96.29% <0%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3eb58f...8033652. Read the comment docs.

@potiuk potiuk merged commit e2524fa into apache:master Jan 19, 2020
potiuk added a commit that referenced this pull request Jan 21, 2020
kaxil pushed a commit that referenced this pull request Jan 22, 2020
kaxil pushed a commit that referenced this pull request Jan 23, 2020
potiuk added a commit that referenced this pull request Jan 26, 2020
kaxil pushed a commit that referenced this pull request Jan 26, 2020
kaxil pushed a commit that referenced this pull request Feb 3, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants