Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXXX] Consistency fixes in new documentation #7207

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 18, 2020


Issue link: Document only change, no JIRA issue

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk potiuk assigned kaxil and unassigned kaxil Jan 18, 2020
@potiuk potiuk requested a review from kaxil January 18, 2020 20:05
CONTRIBUTING.rst Outdated Show resolved Hide resolved
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just a minor comment.

There is also a merge conflict

CONTRIBUTING.rst Outdated Show resolved Hide resolved
@kaxil
Copy link
Member

kaxil commented Jan 20, 2020

Mergeable fails :)

❌ Must include description for the PR
Input : ---
Issue link: Document only change, no JIRA issue

@potiuk potiuk force-pushed the AIRFLOW-XXXX-consistency-fixes-in-new-documentation branch from 2787ead to 2cf0423 Compare January 27, 2020 00:41
@potiuk potiuk merged commit 58cc390 into apache:master Feb 2, 2020
potiuk added a commit that referenced this pull request Feb 2, 2020
Co-authored-by: efedotova <[email protected]>
(cherry picked from commit 58cc390)
kaxil pushed a commit that referenced this pull request Feb 3, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants