Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXXX] Update committers list #7212

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

turbaszek
Copy link
Member

@turbaszek turbaszek commented Jan 19, 2020

I updated the list of committers according to:
http://people.apache.org/phonebook.html?unix=airflow


Issue link: Document only change, no JIRA issue

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like last 3-4 names are not alphabetically ordered

docs/project.rst Outdated
- @msumit (Sumit Maheshwari)
- @pltardif (Patrick Leo Tardif)
- @potiuk (Jarek Potiuk)
- @saguziel (Alex Guziel)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be after "@r39132 Siddharth Anand" for alphabetical order :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will sort it A-Z. I wanted to keep the order consistent with this provided by Apache (I haven't figured the rule :D )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah I thought you wanted to sort it 😄 Apache sorts it based on (Date, Names) the person becomes committer. When Airflow graduated into a Top Level Project, the PPMC became PMC at the same dates. Hence, they are sorted according to Names.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will sort it A-Z. I wanted to keep the order consistent with this provided by Apache (I haven't figured the rule :D )

But the apache list lists apache handles and the project.rst lists github handles?!

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw I am fine with either way. Sorting based on Join Date is fine too :)

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, maybe it might make more sense to keep it by Join Date so that people like Max (original creator of Airflow) remains at the top but I don't have a strong opinion if we sort it by name

@feluelle
Copy link
Member

Actually, maybe it might make more sense to keep it by Join Date so that people like Max (original creator of Airflow) remains at the top but I don't have a strong opinion if we sort it by name

Agree with @kaxil I think it is nice to sort it by join date.

@r39132
Copy link
Contributor

r39132 commented Jan 19, 2020

Actually, maybe it might make more sense to keep it by Join Date so that people like Max (original creator of Airflow) remains at the top but I don't have a strong opinion if we sort it by name

Agree with @kaxil I think it is nice to sort it by join date.

Yes. It's good when certain conventions help us plot the growth of the project. Similar to the apache committer lists on various Apache pages, the intent was to add folks to this list in committer order, which is the order by which they were added as committers to the project.

@potiuk potiuk merged commit a2e91f7 into apache:master Jan 20, 2020
kaxil pushed a commit that referenced this pull request Jan 20, 2020
potiuk pushed a commit that referenced this pull request Jan 21, 2020
kaxil pushed a commit that referenced this pull request Jan 23, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
@turbaszek turbaszek deleted the AIRFLOW-XXXX-committers-list branch March 14, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants