Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6611] Add proxy_fix configs to default_airflow.cfg #7236

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jan 21, 2020

d90ddbd added some new configs (https://github.com/apache/airflow/pull/6901/files fixed a bug in it) which weren't documented and weren't added in default_airflow.cfg

This PR adds them in default_airflow.cfg and documents them.

Default value of 1 (https://github.com/apache/airflow/pull/6901/files#diff-3d86925e55c01b3d8f3cb10def92fd1cR52-R56) is maintained


Issue link: AIRFLOW-6611

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@dimberman dimberman merged commit c890d06 into apache:master Jan 22, 2020
@kaxil kaxil deleted the add-missing-configs branch January 22, 2020 17:10
kaxil added a commit that referenced this pull request Jan 23, 2020
kaxil added a commit that referenced this pull request Jan 23, 2020
potiuk pushed a commit that referenced this pull request Jan 26, 2020
kaxil added a commit that referenced this pull request Jan 26, 2020
kaxil added a commit that referenced this pull request Feb 3, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants