Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6613] center dag on graph view load #7238

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Conversation

houqp
Copy link
Member

@houqp houqp commented Jan 22, 2020

Set up DAG with the right zoom level and center it on graph view page load to help navigate large DAGs.


Issue link: AIRFLOW-6613

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jan 22, 2020
@houqp houqp requested a review from ashb January 22, 2020 00:59
@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #7238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7238   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         791      791           
  Lines       40124    40124           
=======================================
  Hits        34243    34243           
  Misses       5881     5881

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba3fd6...53e067b. Read the comment docs.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change - but I have little experience with the UI to review it - maybe someone else can take a look (it's a good candidate to cherry-pick to 1.10.8 BTW).

@houqp
Copy link
Member Author

houqp commented Jan 30, 2020

@ashb pushed a new change, ready for review

@houqp
Copy link
Member Author

houqp commented Jan 31, 2020

@ashb rebased on latest master, let me know what else i can help to get this merged into master.

@potiuk
Copy link
Member

potiuk commented Feb 2, 2020

Please rebase to latest master @houqp again. Sorry for that - but we had a failing master drama and there is much higher chance the build will succeed. We have still some intermittent errors, but there should be less often.

@houqp
Copy link
Member Author

houqp commented Feb 2, 2020

thanks @potiuk for fixing the master! I have rebased and builds are passing now

@potiuk potiuk merged commit fe686e5 into apache:master Feb 2, 2020
@potiuk
Copy link
Member

potiuk commented Feb 2, 2020

Thanks @houqp ! Nice change!

kaxil pushed a commit that referenced this pull request Feb 3, 2020
@houqp houqp deleted the dagcenter branch February 3, 2020 19:41
kaxil pushed a commit that referenced this pull request Feb 3, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants