Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6627] Email with incorrect DAG not delivered #7250

Merged
merged 2 commits into from
Jan 28, 2020
Merged

[AIRFLOW-6627] Email with incorrect DAG not delivered #7250

merged 2 commits into from
Jan 28, 2020

Conversation

GuzikJakub
Copy link
Contributor

@GuzikJakub GuzikJakub commented Jan 24, 2020


Issue link: AIRFLOW-6627

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change

In case of incorrect DAG execution, I did not receive a notification about the erroneous task completion. This was caused by an incorrect encode of the character

I introduced a lock that tries to send an email with an error, adding the exception that when the email fails, it sends information that the logs could not be thrown into the email.

  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*

Link: https://issues.apache.org/jira/browse/AIRFLOW-6627

  • Unit tests coverage for changes (not needed for documentation changes)

Not needed

* For document-only changes commit message can start with [AIRFLOW-XXXX].

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #7250 into master will decrease coverage by 0.28%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7250      +/-   ##
==========================================
- Coverage   85.33%   85.05%   -0.29%     
==========================================
  Files         791      791              
  Lines       40137    40142       +5     
==========================================
- Hits        34252    34143     -109     
- Misses       5885     5999     +114
Impacted Files Coverage Δ
airflow/models/taskinstance.py 94.71% <66.66%> (-0.25%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 76.47% <0%> (-21.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3f02c4...60b296d. Read the comment docs.

@GuzikJakub GuzikJakub requested review from ashb, feluelle and potiuk and removed request for ashb January 27, 2020 09:34
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@potiuk potiuk merged commit a1bac33 into apache:master Jan 28, 2020
potiuk pushed a commit that referenced this pull request Jan 28, 2020
kaxil pushed a commit that referenced this pull request Feb 3, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Feb 27, 2020

(cherry picked from commit a1bac33)
(cherry picked from commit 507f458)
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants