[AIRFLOW-6628] DAG auto-complete now suggests from all acessible DAGs #7251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mik-laj
reviewed
Jan 24, 2020
robinedwards
force-pushed
the
feature/auto-complete-endpoint
branch
from
ee42829
to
6223a95
Compare
Codecov Report
@@ Coverage Diff @@
## master #7251 +/- ##
=========================================
- Coverage 86.81% 86.8% -0.01%
=========================================
Files 893 893
Lines 42193 42208 +15
=========================================
+ Hits 36629 36639 +10
- Misses 5564 5569 +5
Continue to review full report at Codecov.
|
robinedwards
force-pushed
the
feature/auto-complete-endpoint
branch
2 times, most recently
from
684299e
to
ea40e7f
Compare
ashb
reviewed
Jan 31, 2020
robinedwards
force-pushed
the
feature/auto-complete-endpoint
branch
from
ea40e7f
to
5f8e608
Compare
|
Please rebase to latest master @robinedwards - we had a failing master drama and there is much higher chance the build will succeed. We have still some intermittent errors, but there should be less often. |
robinedwards
force-pushed
the
feature/auto-complete-endpoint
branch
from
5f8e608
to
13d2831
Compare
|
Rebased @potiuk all green, nice work on fixing master! |
robinedwards
force-pushed
the
feature/auto-complete-endpoint
branch
from
13d2831
to
a9ca06b
Compare
robinedwards
force-pushed
the
feature/auto-complete-endpoint
branch
7 times, most recently
from
fe05f2b
to
f8ace25
Compare
The auto complete on the dag search box utilises the page search context which prevents auto completing dags which dont match the current query. On the dags page with no search provided it executes a query that loads every dag_id in the system to pass to the typeahead widget. On systems with a lot of dags this makes the page large and slow. Add a JSON endpoint to provide correct auto complete behaviour and reduce page load time.
robinedwards
force-pushed
the
feature/auto-complete-endpoint
branch
from
f8ace25
to
0e47b61
Compare
ashb
reviewed
Feb 24, 2020
ashb
approved these changes
Feb 24, 2020
ashb
changed the title
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
…apache#7251) The auto complete on the dag search box utilises the page search context which prevents auto completing dags which dont match the current query. On the dags page with no search provided it executes a query that loads every dag_id in the system to pass to the typeahead widget. On systems with a lot of dags this makes the page large and slow. Add a JSON endpoint to provide correct auto complete behaviour and reduce page load time.
kaxil
added a commit
that referenced
this pull request
Mar 31, 2020
…#7251) The auto complete on the dag search box utilises the page search context which prevents auto completing dags which dont match the current query. On the dags page with no search provided it executes a query that loads every dag_id in the system to pass to the typeahead widget. On systems with a lot of dags this makes the page large and slow. Add a JSON endpoint to provide correct auto complete behaviour and reduce page load time. cherry-picked from 1a9d218
kaxil
added a commit
that referenced
this pull request
Mar 31, 2020
…#7251) The auto complete on the dag search box utilises the page search context which prevents auto completing dags which dont match the current query. On the dags page with no search provided it executes a query that loads every dag_id in the system to pass to the typeahead widget. On systems with a lot of dags this makes the page large and slow. Add a JSON endpoint to provide correct auto complete behaviour and reduce page load time. cherry-picked from 1a9d218
kaxil
added a commit
that referenced
this pull request
Mar 31, 2020
…#7251) The auto complete on the dag search box utilises the page search context which prevents auto completing dags which dont match the current query. On the dags page with no search provided it executes a query that loads every dag_id in the system to pass to the typeahead widget. On systems with a lot of dags this makes the page large and slow. Add a JSON endpoint to provide correct auto complete behaviour and reduce page load time. cherry-picked from 1a9d218
kaxil
added a commit
that referenced
this pull request
Apr 1, 2020
…#7251) The auto complete on the dag search box utilises the page search context which prevents auto completing dags which dont match the current query. On the dags page with no search provided it executes a query that loads every dag_id in the system to pass to the typeahead widget. On systems with a lot of dags this makes the page large and slow. Add a JSON endpoint to provide correct auto complete behaviour and reduce page load time. cherry-picked from 1a9d218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto complete on the dag search box utilises the page search context
which prevents auto completing dags which dont match the current query.
On the dags page with no search provided it executes a query that loads
every dag_id in the system to pass to the typeahead widget. On systems
with a lot of dags this makes the page large and slow.
Add a JSON endpoint to provide correct auto complete behaviour and
reduce page load time.
Issue link: AIRFLOW-6628
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*