Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6641] Better diagnostics for kubernetes flaky tests #7261

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 25, 2020

Kubernetes tests are sometimes flaky - they do not reach desired state and we
do not know why. We need to make it less flaky and have enough diagnostics to
understand what's going on.


Issue link: AIRFLOW-6641

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

Kubernetes tests are sometimes flaky - they do not reach desired state and we
do not know why. We need to make it less flaky and have enough diagnostics to
understand what's going on.
@codecov-io
Copy link

codecov-io commented Jan 25, 2020

Codecov Report

Merging #7261 into master will increase coverage by 52.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7261       +/-   ##
===========================================
+ Coverage   32.96%   85.05%   +52.09%     
===========================================
  Files         791      791               
  Lines       40137    40137               
===========================================
+ Hits        13231    34139    +20908     
+ Misses      26906     5998    -20908
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-43.8%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 76.47% <0%> (-21.18%) ⬇️
airflow/bin/airflow 84.61% <0%> (ø) ⬆️
airflow/plugins_manager.py 87.57% <0%> (+0.62%) ⬆️
airflow/bin/cli.py 94.73% <0%> (+2.1%) ⬆️
airflow/exceptions.py 100% <0%> (+3.57%) ⬆️
airflow/www/forms.py 100% <0%> (+4.44%) ⬆️
... and 645 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6584e0d...0c384c2. Read the comment docs.

@potiuk potiuk merged commit 4e7bb5f into apache:master Jan 25, 2020
potiuk added a commit that referenced this pull request Jan 26, 2020
Kubernetes tests are sometimes flaky - they do not reach desired state and we
do not know why. We need to make it less flaky and have enough diagnostics to
understand what's going on.

(cherry picked from commit 4e7bb5f)
kaxil pushed a commit that referenced this pull request Jan 26, 2020
Kubernetes tests are sometimes flaky - they do not reach desired state and we
do not know why. We need to make it less flaky and have enough diagnostics to
understand what's going on.

(cherry picked from commit 4e7bb5f)
kaxil pushed a commit that referenced this pull request Feb 3, 2020
Kubernetes tests are sometimes flaky - they do not reach desired state and we
do not know why. We need to make it less flaky and have enough diagnostics to
understand what's going on.

(cherry picked from commit 4e7bb5f)
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
…7261)

Kubernetes tests are sometimes flaky - they do not reach desired state and we
do not know why. We need to make it less flaky and have enough diagnostics to
understand what's going on.
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
…7261)

Kubernetes tests are sometimes flaky - they do not reach desired state and we
do not know why. We need to make it less flaky and have enough diagnostics to
understand what's going on.

(cherry picked from commit 4e7bb5f)
(cherry picked from commit eb3974b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants