[AIRFLOW-6662] Switch to --init docker flag for signal propagation #7278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
approved these changes
Jan 28, 2020
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #7278 +/- ##
==========================================
+ Coverage 85.2% 85.46% +0.26%
==========================================
Files 840 851 +11
Lines 40336 40403 +67
==========================================
+ Hits 34367 34531 +164
+ Misses 5969 5872 -97
Continue to review full report at Codecov.
|
We are now using native --init flag of docker run and init: parameter of docker compose to pass signals and reap child processes
potiuk
force-pushed
the
AIRFLOW-6662-install-dumb-init
branch
from
9343807
to
ff50596
Compare
potiuk
changed the title
|
@ashb @nuclearpinguin @mik-laj @feluelle -> I fixed it all by --init flag. |
|
@ashb @mik-laj @nuclearpinguin -> Seems the init flag is good now. I tested it and it all works fine including killing the running local builds with Ctrl-C. That was the biggest problem before dumb-init introduction and it works perfectly now. |
potiuk
added a commit
to PolideaInternal/airflow
that referenced
this pull request
Feb 2, 2020
…ation (apache#7278)" This reverts commit d1bf343.
potiuk
added a commit
that referenced
this pull request
Feb 2, 2020
* Revert "[AIRFLOW-6662] Switch to --init docker flag for signal propagation (#7278)" This reverts commit d1bf343. * [AIRFLOW-6662] return back the dumb-init - installed by apt We had stability problems with tests with --init flag so we are going back to it
potiuk
added a commit
that referenced
this pull request
Feb 2, 2020
* Revert "[AIRFLOW-6662] Switch to --init docker flag for signal propagation (#7278)" This reverts commit d1bf343. * [AIRFLOW-6662] return back the dumb-init - installed by apt We had stability problems with tests with --init flag so we are going back to it (cherry picked from commit 945b988)
kaxil
pushed a commit
that referenced
this pull request
Feb 3, 2020
* Revert "[AIRFLOW-6662] Switch to --init docker flag for signal propagation (#7278)" This reverts commit d1bf343. * [AIRFLOW-6662] return back the dumb-init - installed by apt We had stability problems with tests with --init flag so we are going back to it (cherry picked from commit 945b988)
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
…pache#7278) We are now using native --init flag of docker run and init: parameter of docker compose to pass signals and reap child processes
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
* Revert "[AIRFLOW-6662] Switch to --init docker flag for signal propagation (apache#7278)" This reverts commit d1bf343. * [AIRFLOW-6662] return back the dumb-init - installed by apt We had stability problems with tests with --init flag so we are going back to it
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 30, 2020
…pache#7278) We are now using native --init flag of docker run and init: parameter of docker compose to pass signals and reap child processes (cherry picked from commit d1bf343) (cherry picked from commit 85cde61)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 30, 2020
* Revert "[AIRFLOW-6662] Switch to --init docker flag for signal propagation (apache#7278)" This reverts commit d1bf343. * [AIRFLOW-6662] return back the dumb-init - installed by apt We had stability problems with tests with --init flag so we are going back to it (cherry picked from commit 945b988) (cherry picked from commit 3ca84ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now using native --init flag of docker run and init: parameter
of docker compose to pass signals and reap child processes
Issue link: AIRFLOW-6662
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.