Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6666] Bump css-loader to resolve js-yaml advisories #7283

Merged
merged 1 commit into from
Feb 2, 2020
Merged

[AIRFLOW-6666] Bump css-loader to resolve js-yaml advisories #7283

merged 1 commit into from
Feb 2, 2020

Conversation

ryw
Copy link
Member

@ryw ryw commented Jan 28, 2020

Bump css-loader to resolve js-yaml advisory


Issue link: AIRFLOW-6666

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jan 28, 2020
@ryw ryw changed the title [AIRFLOW-6666] Resolve js-yaml advisory [AIRFLOW-6666] Bump css-loader to resolve js-yaml advisory Jan 28, 2020
@ryw ryw changed the title [AIRFLOW-6666] Bump css-loader to resolve js-yaml advisory [AIRFLOW-6666] Bump css-loader to resolve js-yaml advisories Jan 28, 2020
@potiuk
Copy link
Member

potiuk commented Jan 29, 2020

Lockfile needs to be updated I am afraid as well.

@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #7283 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7283      +/-   ##
=========================================
+ Coverage   85.45%   85.5%   +0.05%     
=========================================
  Files         841     864      +23     
  Lines       40363   40455      +92     
=========================================
+ Hits        34491   34592     +101     
+ Misses       5872    5863       -9
Impacted Files Coverage Δ
airflow/operators/mysql_to_hive.py 0% <0%> (-100%) ⬇️
airflow/operators/s3_to_hive_operator.py 0% <0%> (-93.97%) ⬇️
airflow/contrib/operators/s3_to_sftp_operator.py 100% <0%> (ø) ⬆️
airflow/operators/google_api_to_s3_transfer.py 100% <0%> (ø) ⬆️
airflow/contrib/operators/hive_to_dynamodb.py 100% <0%> (ø) ⬆️
airflow/contrib/operators/file_to_wasb.py 100% <0%> (ø) ⬆️
airflow/operators/mssql_to_hive.py 100% <0%> (ø) ⬆️
...irflow/contrib/operators/gcs_to_gdrive_operator.py 100% <0%> (ø) ⬆️
airflow/contrib/operators/gcs_to_s3.py 100% <0%> (ø) ⬆️
airflow/operators/hive_to_samba_operator.py 100% <0%> (ø) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4c6cc...a7a74b5. Read the comment docs.

@ashb
Copy link
Member

ashb commented Jan 29, 2020

@ryw This one is conflicting now after merging the other two.

@ryw
Copy link
Member Author

ryw commented Jan 29, 2020

ok - rebased off master and force pushed

@kaxil kaxil merged commit 17464bd into apache:master Feb 2, 2020
@ryw ryw deleted the bump-js-yaml branch February 3, 2020 14:31
kaxil pushed a commit that referenced this pull request Feb 3, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 10, 2020
(cherry-picked from 17464bd)

(cherry picked from commit caa3567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants