[AIRFLOW-6686] Fix syntax error constructing list of process ids #7298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Construction of list of pids passed in kill command raises a Syntax error because ordering of the arguments to `map` function doesn't conform to function parameter definition. A list comprehension replaces the existing `map` function to make the code forward compatible with Python 3 and at the same time expand to a list of pids.
osule
changed the title
mik-laj
approved these changes
Jan 31, 2020
|
Travis is sad. I restarted failed jobs. |
Codecov Report
@@ Coverage Diff @@
## master #7298 +/- ##
==========================================
+ Coverage 83.85% 85.59% +1.74%
==========================================
Files 863 863
Lines 40488 40509 +21
==========================================
+ Hits 33951 34675 +724
+ Misses 6537 5834 -703
Continue to review full report at Codecov.
|
kaxil
pushed a commit
that referenced
this pull request
Feb 3, 2020
Construction of list of pids passed in kill command raises a Syntax error because ordering of the arguments to `map` function doesn't conform to function parameter definition. A list comprehension replaces the existing `map` function to make the code forward compatible with Python 3 and at the same time expand to a list of pids. (cherry picked from commit d1cedc4)
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
…che#7298) Construction of list of pids passed in kill command raises a Syntax error because ordering of the arguments to `map` function doesn't conform to function parameter definition. A list comprehension replaces the existing `map` function to make the code forward compatible with Python 3 and at the same time expand to a list of pids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construction of list of pids passed in kill command raises a Syntax error because
ordering of the arguments to
mapfunction doesn't conform to functionparameter definition.
A list comprehension replaces the existing
mapfunction to make the codeforward compatible with Python 3 and at the same time expand to a list of pids.
Issue link: AIRFLOW-6686
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*Unit tests coverage for changes (not needed for documentation changes)Commits follow "How to write a good git commit message"Relevant documentation is updated including usage instructions.* For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.