Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6695] Add DAG run configuration to UI #7312

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

dacohen
Copy link
Contributor

@dacohen dacohen commented Jan 31, 2020


Issue link: AIRFLOW-6695

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jan 31, 2020
@potiuk
Copy link
Member

potiuk commented Feb 2, 2020

Please rebase to latest master @dacohen - we had a failing master drama and there is much higher chance the build will succeed. We have still some intermittent errors, but there should be less often.

@dacohen
Copy link
Contributor Author

dacohen commented Feb 5, 2020

@potiuk Rebase is done. Let me know if you need anything else.

@potiuk
Copy link
Member

potiuk commented Feb 5, 2020

I am not really experienced in that part of the code (UI)? I will let others take a look (@ashb /@kaxil @mik-laj ). ?

airflow/www/views.py Outdated Show resolved Hide resolved
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't tested that a GET request shows the form -- could you please?

@codecov-io
Copy link

codecov-io commented Feb 5, 2020

Codecov Report

Merging #7312 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7312      +/-   ##
==========================================
+ Coverage   86.21%   86.35%   +0.13%     
==========================================
  Files         871      871              
  Lines       40570    40636      +66     
==========================================
+ Hits        34979    35091     +112     
+ Misses       5591     5545      -46
Impacted Files Coverage Δ
airflow/www/views.py 76.22% <100%> (+0.14%) ⬆️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 93.61% <0%> (-4.04%) ⬇️
...providers/google/cloud/example_dags/example_gcs.py 96.29% <0%> (-3.71%) ⬇️
airflow/www/app.py 94.24% <0%> (ø) ⬆️
...rflow/providers/mysql/operators/presto_to_mysql.py 100% <0%> (ø) ⬆️
...flow/providers/amazon/aws/hooks/cloud_formation.py 96.77% <0%> (ø) ⬆️
.../providers/amazon/aws/operators/cloud_formation.py 100% <0%> (ø) ⬆️
...ow/providers/amazon/aws/sensors/cloud_formation.py 100% <0%> (ø) ⬆️
airflow/utils/dag_processing.py 87.93% <0%> (ø) ⬆️
airflow/api/common/experimental/trigger_dag.py 98.07% <0%> (+0.11%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c72f4...ec3174d. Read the comment docs.

@dacohen dacohen requested a review from ashb February 5, 2020 20:12
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also post a screenshot of what this new page looks like please?

airflow/www/views.py Outdated Show resolved Hide resolved
@dacohen
Copy link
Contributor Author

dacohen commented Feb 6, 2020

@ashb Made those changes. Here are screenshots of the page on first load, and after entering an invalid payload. Thanks again for your help on this!

Screen Shot 2020-02-06 at 10 13 31 AM

Screen Shot 2020-02-06 at 10 14 06 AM

airflow/www/views.py Outdated Show resolved Hide resolved
@dacohen
Copy link
Contributor Author

dacohen commented Feb 6, 2020

@ashb Updated again. New error screenshot attached.

Screen Shot 2020-02-06 at 11 11 25 AM

@ashb ashb merged commit f0c31c5 into apache:master Feb 6, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil added a commit that referenced this pull request Mar 31, 2020
kaxil added a commit that referenced this pull request Mar 31, 2020
kaxil added a commit that referenced this pull request Mar 31, 2020
@josh-gree
Copy link

Why was this not an optional screen!?

@kaxil
Copy link
Member

kaxil commented Aug 12, 2020

Why was this not an optional screen!?

The number of clicks are the same to trigger any job, previously you had a prompt box on the same window, now you need to Trigger button on a different window -- that is the only difference. Would love to hear your use-case where you would like to have this optional.

@matthewpick
Copy link

Is there an easy way to view the Configuration for a DAG run after I click Trigger?
Sometimes I am uncertain how a specific DAG run was triggered (unless I look at the task logs).

@kaxil
Copy link
Member

kaxil commented Oct 9, 2020

Is there an easy way to view the Configuration for a DAG run after I click Trigger?
Sometimes I am uncertain how a specific DAG run was triggered (unless I look at the task logs).

@matthewpick You can go Browse -> DagRun and check the conf column to view what you passed:

image

@matthewpick
Copy link

@kaxil I see! I had to enable RBAC to see the Conf column. We're good now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants