-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6695] Add DAG run configuration to UI #7312
Conversation
cb93706
to
1347603
Compare
Please rebase to latest master @dacohen - we had a failing master drama and there is much higher chance the build will succeed. We have still some intermittent errors, but there should be less often. |
1347603
to
1cd0a12
Compare
@potiuk Rebase is done. Let me know if you need anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You haven't tested that a GET request shows the form -- could you please?
1cd0a12
to
3da126e
Compare
Codecov Report
@@ Coverage Diff @@
## master #7312 +/- ##
==========================================
+ Coverage 86.21% 86.35% +0.13%
==========================================
Files 871 871
Lines 40570 40636 +66
==========================================
+ Hits 34979 35091 +112
+ Misses 5591 5545 -46
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also post a screenshot of what this new page looks like please?
3da126e
to
749c420
Compare
@ashb Made those changes. Here are screenshots of the page on first load, and after entering an invalid payload. Thanks again for your help on this! |
749c420
to
ec3174d
Compare
@ashb Updated again. New error screenshot attached. |
Why was this not an optional screen!? |
The number of clicks are the same to trigger any job, previously you had a prompt box on the same window, now you need to Trigger button on a different window -- that is the only difference. Would love to hear your use-case where you would like to have this optional. |
Is there an easy way to view the Configuration for a DAG run after I click Trigger? |
@matthewpick You can go Browse -> DagRun and check the conf column to view what you passed: |
@kaxil I see! I had to enable RBAC to see the |
Issue link: AIRFLOW-6695
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.