Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXXX] Add scheduler in production section to best practices doc #7351

Merged
merged 1 commit into from
Feb 4, 2020
Merged

[AIRFLOW-XXXX] Add scheduler in production section to best practices doc #7351

merged 1 commit into from
Feb 4, 2020

Conversation

ryw
Copy link
Member

@ryw ryw commented Feb 3, 2020


Issue link: Document only change, no JIRA issue

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@ryw ryw requested a review from kaxil February 3, 2020 22:28
docs/best-practices.rst Outdated Show resolved Hide resolved
docs/best-practices.rst Outdated Show resolved Hide resolved
@ryw
Copy link
Member Author

ryw commented Feb 4, 2020

@kaxil thanks for suggestions - i accepted your changes, then merged back into one commit + forced pushed to my branch. is that the right way?

@ryw
Copy link
Member Author

ryw commented Feb 4, 2020

@kaxil hmm looks like random test fail?

@potiuk potiuk merged commit 34f5d6f into apache:master Feb 4, 2020
@potiuk
Copy link
Member

potiuk commented Feb 4, 2020

Thanks @ryw !

@kaxil
Copy link
Member

kaxil commented Feb 4, 2020

@kaxil thanks for suggestions - i accepted your changes, then merged back into one commit + forced pushed to my branch. is that the right way?

Yup :)

galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
@kaxil kaxil added this to the Airflow 1.10.11 milestone Jun 30, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
@kaxil kaxil added the type:doc label Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
@ryw ryw deleted the add-scheduler-bestpractice branch August 26, 2020 12:36
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants