Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6753] Run REST API tests when DAGs are serialized #7352

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

anitakar
Copy link
Contributor

@anitakar anitakar commented Feb 3, 2020


Issue link: AIRFLOW-6753

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Feb 3, 2020
@anitakar anitakar requested a review from mik-laj February 3, 2020 15:33
with conf_vars(
{("core", "store_serialized_dags"): self.dag_serialzation}
):
url_template = '/api/experimental/dags/{}/tasks/{}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using conf_vars as decorator will reduce number of code changes :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work properly withparameterized_class

@mik-laj
Copy link
Member

mik-laj commented Feb 3, 2020

Travis is sad. Can you take care of him?

@codecov-io
Copy link

codecov-io commented Feb 6, 2020

Codecov Report

Merging #7352 into master will decrease coverage by 54.16%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7352       +/-   ##
===========================================
- Coverage   86.24%   32.08%   -54.17%     
===========================================
  Files         871      870        -1     
  Lines       40627    40620        -7     
===========================================
- Hits        35039    13031    -22008     
- Misses       5588    27589    +22001
Impacted Files Coverage Δ
airflow/api/common/experimental/__init__.py 25.92% <0%> (-74.08%) ⬇️
...low/contrib/operators/wasb_delete_blob_operator.py 0% <0%> (-100%) ⬇️
...ing_platform/example_dags/example_display_video.py 0% <0%> (-100%) ⬇️
airflow/contrib/hooks/vertica_hook.py 0% <0%> (-100%) ⬇️
airflow/contrib/sensors/__init__.py 0% <0%> (-100%) ⬇️
airflow/hooks/mssql_hook.py 0% <0%> (-100%) ⬇️
airflow/hooks/webhdfs_hook.py 0% <0%> (-100%) ⬇️
airflow/contrib/sensors/emr_base_sensor.py 0% <0%> (-100%) ⬇️
...irflow/contrib/operators/slack_webhook_operator.py 0% <0%> (-100%) ⬇️
airflow/hooks/jdbc_hook.py 0% <0%> (-100%) ⬇️
... and 740 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976ec4d...9bb2549. Read the comment docs.

@mik-laj mik-laj merged commit f3eea3e into apache:master Feb 7, 2020
@anitakar
Copy link
Contributor Author

anitakar commented Feb 7, 2020

Connected to another ticket https://issues.apache.org/jira/browse/AIRFLOW-6753

@anitakar anitakar changed the title [AIRFLOW-6683] Run REST API tests when DAGs are serialized [AIRFLOW-6753] Run REST API tests when DAGs are serialized Feb 7, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil added a commit that referenced this pull request Mar 23, 2020
kaxil added a commit that referenced this pull request Mar 30, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Apr 7, 2020
Cherry-pick of apache/airflow#7352

Change-Id: I849831fde2558a9c1d04a4da08db5fd8f0526e9e
GitOrigin-RevId: 80d28e0595bc6f70d4319f09960c51ddf289477b
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Apr 8, 2020
Cherry-pick of apache/airflow#7352

Change-Id: I382f202907c83700cfff88c26921b1693cc1a015
GitOrigin-RevId: 06c5f65794b1dc5420152e8e569989a3d07f7a50
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Apr 8, 2020
Cherry-pick of apache/airflow#7352

Change-Id: I8708d9750712ab308fe075c6f24ee22ae3fd9d44
GitOrigin-RevId: fd496dd543cff745f668283414b149e36c959561
@anitakar anitakar deleted the tests_for_serialized_dag branch May 7, 2020 18:42
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 9, 2021
Cherry-pick of apache/airflow#7352

Change-Id: I849831fde2558a9c1d04a4da08db5fd8f0526e9e
GitOrigin-RevId: 31f7946d0ccb90760041313694adab0a991275c4
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 10, 2021
Cherry-pick of apache/airflow#7352

Change-Id: I849831fde2558a9c1d04a4da08db5fd8f0526e9e
GitOrigin-RevId: 80d28e0595bc6f70d4319f09960c51ddf289477b
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 15, 2021
Cherry-pick of apache/airflow#7352

Change-Id: I382f202907c83700cfff88c26921b1693cc1a015
GitOrigin-RevId: 06c5f65794b1dc5420152e8e569989a3d07f7a50
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 15, 2021
Cherry-pick of apache/airflow#7352

Change-Id: I8708d9750712ab308fe075c6f24ee22ae3fd9d44
GitOrigin-RevId: fd496dd543cff745f668283414b149e36c959561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants