Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6727] Fix minor bugs in Release Management scripts #7355

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Feb 3, 2020

There are some minor issues:

  • Click needs to be >= 7.0
  • Path of CHANGELOG.txt
  • Path of template files to send automated emails

Issue link: AIRFLOW-6727

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@codecov-io
Copy link

codecov-io commented Feb 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@96f8343). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7355   +/-   ##
=========================================
  Coverage          ?   86.06%           
=========================================
  Files             ?      871           
  Lines             ?    40627           
  Branches          ?        0           
=========================================
  Hits              ?    34966           
  Misses            ?     5661           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f8343...6bf4f39. Read the comment docs.

@kaxil kaxil merged commit e681d3a into apache:master Feb 4, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
@kaxil kaxil deleted the fix-rm-scripts branch March 17, 2020 01:59
kaxil added a commit that referenced this pull request Mar 17, 2020
kaxil added a commit that referenced this pull request Mar 19, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants