[AIRFLOW-6740] Remove Undocumented, Deprecated, Dysfunctional PROXY_FIX_NUM_PROXIES #7359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
sbrandtb
force-pushed
the
remove_deprecated_and_unused_config
branch
2 times, most recently
from
aa992b8
to
a4712a5
Compare
sbrandtb
changed the title
sbrandtb
force-pushed
the
remove_deprecated_and_unused_config
branch
from
a4712a5
to
bd35e3d
Compare
|
Change looks good, but this needs a jira ticket please. |
sbrandtb
force-pushed
the
remove_deprecated_and_unused_config
branch
3 times, most recently
from
f2f7fad
to
2b66b2a
Compare
sbrandtb
changed the title
…IX_NUM_PROXIES This parameter is deprecated by werkzeug, see: https://github.com/pallets/werkzeug/blob/0.16.1/src/werkzeug/middleware/proxy_fix.py#L113-L120 However, it is also broken. The value is acquired as string from the config, while it should be int like the other `x_*` attributes. Those were fixed in apache#6901, but `num_proxies` was forgotten. I think we can safely remove it because: * There is virtually no possibility that someone is using that parameter in their config without raising an exception. * The configuration variable is not present in Airflow's docs or anywhere else anymore. The removed line is the only trace of it. More details: https://issues.apache.org/jira/browse/AIRFLOW-6740
sbrandtb
force-pushed
the
remove_deprecated_and_unused_config
branch
from
2b66b2a
to
820b3a8
Compare
|
@ashb Done. |
ashb
approved these changes
Feb 5, 2020
|
@ashb weird. One CI job failed with "fatal: unable to access 'https://github.com/apache/airflow.git/': Failed to connect to github.com port 443: Connection timed out". Looks like it could be a temporary issue. How to retrigger the CI? |
|
I restarted job. |
|
Awesome work, congrats on your first merged pull request! |
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
…IX_NUM_PROXIES (apache#7359) This parameter is deprecated by werkzeug, see: https://github.com/pallets/werkzeug/blob/0.16.1/src/werkzeug/middleware/proxy_fix.py#L113-L120 However, it is also broken. The value is acquired as string from the config, while it should be int like the other `x_*` attributes. Those were fixed in apache#6901, but `num_proxies` was forgotten. I think we can safely remove it because: * There is virtually no possibility that someone is using that parameter in their config without raising an exception. * The configuration variable is not present in Airflow's docs or anywhere else anymore. The removed line is the only trace of it. More details: https://issues.apache.org/jira/browse/AIRFLOW-6740
kaxil
pushed a commit
that referenced
this pull request
Mar 17, 2020
…IX_NUM_PROXIES (#7359) This parameter is deprecated by werkzeug, see: https://github.com/pallets/werkzeug/blob/0.16.1/src/werkzeug/middleware/proxy_fix.py#L113-L120 However, it is also broken. The value is acquired as string from the config, while it should be int like the other `x_*` attributes. Those were fixed in #6901, but `num_proxies` was forgotten. I think we can safely remove it because: * There is virtually no possibility that someone is using that parameter in their config without raising an exception. * The configuration variable is not present in Airflow's docs or anywhere else anymore. The removed line is the only trace of it. More details: https://issues.apache.org/jira/browse/AIRFLOW-6740 (cherry picked from commit 936f7fe)
kaxil
pushed a commit
that referenced
this pull request
Mar 19, 2020
…IX_NUM_PROXIES (#7359) This parameter is deprecated by werkzeug, see: https://github.com/pallets/werkzeug/blob/0.16.1/src/werkzeug/middleware/proxy_fix.py#L113-L120 However, it is also broken. The value is acquired as string from the config, while it should be int like the other `x_*` attributes. Those were fixed in #6901, but `num_proxies` was forgotten. I think we can safely remove it because: * There is virtually no possibility that someone is using that parameter in their config without raising an exception. * The configuration variable is not present in Airflow's docs or anywhere else anymore. The removed line is the only trace of it. More details: https://issues.apache.org/jira/browse/AIRFLOW-6740 (cherry picked from commit 936f7fe)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 19, 2020
…IX_NUM_PROXIES (apache#7359) This parameter is deprecated by werkzeug, see: https://github.com/pallets/werkzeug/blob/0.16.1/src/werkzeug/middleware/proxy_fix.py#L113-L120 However, it is also broken. The value is acquired as string from the config, while it should be int like the other `x_*` attributes. Those were fixed in apache#6901, but `num_proxies` was forgotten. I think we can safely remove it because: * There is virtually no possibility that someone is using that parameter in their config without raising an exception. * The configuration variable is not present in Airflow's docs or anywhere else anymore. The removed line is the only trace of it. More details: https://issues.apache.org/jira/browse/AIRFLOW-6740 (cherry picked from commit 936f7fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is deprecated by werkzeug, see: https://github.com/pallets/werkzeug/blob/0.16.1/src/werkzeug/middleware/proxy_fix.py#L113-L120
However, it is also broken. The value is acquired as string from the config, while it should be int like the other
x_*attributes. Those were fixed in #6901, butnum_proxieswas forgotten.I think we can safely remove it because:
https://issues.apache.org/jira/browse/AIRFLOW-6740