-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible #7377
[AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible #7377
Conversation
I'd like to try upgrading rather then pinning first. (I'll make the pr now) |
Might be solved differently https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1581028413361000 |
For the 1-10 release branch at least we can't upgrade: Flask-Admin hasn't yet published the fix pallets-eco/flask-admin#1951 |
Lets merge this one and push it out, then I'll look at unpinning/upgrading all the deps as needed on master to update it |
I think no matter what, it's safer to downgrade werkzeug for 1.10.x rather than upgrade flask. |
Oh FAB is broken too because of it's dep on |
Codecov Report
@@ Coverage Diff @@
## master #7377 +/- ##
==========================================
- Coverage 86.35% 86.07% -0.29%
==========================================
Files 871 871
Lines 40636 40636
==========================================
- Hits 35091 34976 -115
- Misses 5545 5660 +115
Continue to review full report at Codecov.
|
just missed 1.10.8 release :( |
|
…apache#7377) (cherry picked from commit ed76eeb)
…apache#7377) (cherry picked from commit ed76eeb)
Since `werkzeug` is not a direct dependency this can be removed. Previously this was pinned for apache#7377 (flask-admin) and was later unpinned in apache#11610
Issue link: AIRFLOW-6751
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.