Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6751] Pin Werkzeug < 1.0.0 release - 1.0.0 is not compatible #7377

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 7, 2020


Issue link: AIRFLOW-6751

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk potiuk requested review from ashb and kaxil February 7, 2020 09:25
@ashb
Copy link
Member

ashb commented Feb 7, 2020

I'd like to try upgrading rather then pinning first. (I'll make the pr now)

@potiuk
Copy link
Member Author

potiuk commented Feb 7, 2020

@ashb
Copy link
Member

ashb commented Feb 7, 2020

For the 1-10 release branch at least we can't upgrade: Flask-Admin hasn't yet published the fix pallets-eco/flask-admin#1951

@ashb
Copy link
Member

ashb commented Feb 7, 2020

Lets merge this one and push it out, then I'll look at unpinning/upgrading all the deps as needed on master to update it

@potiuk
Copy link
Member Author

potiuk commented Feb 7, 2020

For the 1-10 release branch at least we can't upgrade: Flask-Admin hasn't yet published the fix flask-admin/flask-admin#1951

I think no matter what, it's safer to downgrade werkzeug for 1.10.x rather than upgrade flask.

@ashb
Copy link
Member

ashb commented Feb 7, 2020

Oh FAB is broken too because of it's dep on flask-babel<1

@codecov-io
Copy link

Codecov Report

Merging #7377 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7377      +/-   ##
==========================================
- Coverage   86.35%   86.07%   -0.29%     
==========================================
  Files         871      871              
  Lines       40636    40636              
==========================================
- Hits        35091    34976     -115     
- Misses       5545     5660     +115
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0%> (-45.08%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 70.21% <0%> (-23.41%) ⬇️
airflow/utils/dag_processing.py 88.12% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46be81...ad18e97. Read the comment docs.

@potiuk potiuk merged commit 52db2ab into apache:master Feb 7, 2020
@tooptoop4
Copy link
Contributor

just missed 1.10.8 release :(

@ddelange
Copy link
Contributor

ddelange commented Feb 7, 2020

ref pallets/flask#3489

$ pipgrip --tree -vvv flask_admin

flask-admin (1.5.4)
├── flask>=0.7 (1.1.1)
│   ├── click>=5.1 (7.0)
│   ├── itsdangerous>=0.24 (1.1.0)
│   ├── jinja2>=2.10.1 (2.11.1)
│   │   └── markupsafe>=0.23 (1.1.1)
│   └── werkzeug>=0.15 (1.0.0)
└── wtforms (2.2.1)

ashb pushed a commit to astronomer/airflow that referenced this pull request Feb 10, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Jun 17, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Oct 26, 2020
Since `werkzeug` is not a direct dependency this can be removed. Previously this was pinned for apache#7377 (flask-admin) and was later unpinned in apache#11610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants