Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6767] Correct name for default Athena workgroup #7394

Merged
merged 2 commits into from
Feb 10, 2020
Merged

[AIRFLOW-6767] Correct name for default Athena workgroup #7394

merged 2 commits into from
Feb 10, 2020

Conversation

bhavika
Copy link
Contributor

@bhavika bhavika commented Feb 10, 2020


Issue link: AIRFLOW-6767

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • [] I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the provider:amazon-aws AWS/Amazon - related issues label Feb 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #7394 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7394      +/-   ##
==========================================
- Coverage    86.3%   86.12%   -0.18%     
==========================================
  Files         871      871              
  Lines       40660    40660              
==========================================
- Hits        35091    35020      -71     
- Misses       5569     5640      +71
Impacted Files Coverage Δ
airflow/providers/amazon/aws/hooks/athena.py 67.18% <ø> (ø) ⬆️
airflow/providers/amazon/aws/operators/athena.py 74.5% <ø> (ø) ⬆️
...w/providers/apache/hive/operators/mysql_to_hive.py 35.84% <0%> (-64.16%) ⬇️
airflow/security/kerberos.py 30.43% <0%> (-45.66%) ⬇️
airflow/providers/mysql/operators/mysql.py 55% <0%> (-45%) ⬇️
airflow/providers/apache/hive/hooks/hive.py 76.02% <0%> (-1.54%) ⬇️
airflow/hooks/dbapi_hook.py 90.9% <0%> (-0.83%) ⬇️
airflow/jobs/scheduler_job.py 89.19% <0%> (-0.15%) ⬇️
airflow/utils/dag_processing.py 88.12% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ba6d6...0fb123a. Read the comment docs.

@bhavika bhavika requested review from potiuk and ashb February 10, 2020 16:04
@bhavika
Copy link
Contributor Author

bhavika commented Feb 10, 2020

👋 I'm not entirely sure how CodeCov does this but I haven't reduced the scope of any tests or deleted them so the reduction in coverage is probably due to something else.

@mik-laj mik-laj merged commit b7aa778 into apache:master Feb 10, 2020
@bhavika bhavika deleted the athena-wg branch February 10, 2020 17:19
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
* Change default wg name

* Change workgroup in tests
kaxil pushed a commit that referenced this pull request Mar 17, 2020
kaxil pushed a commit that referenced this pull request Mar 19, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants