-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6820] split breeze into functions #7433
[AIRFLOW-6820] split breeze into functions #7433
Conversation
Hey @dimberman -> this is part of the #6500 -> I split it into smaller pieces as you suggested. First was #7430 - already approved by Ash. Now this one which introduces functions to breeze and makes it much easier to read. The next one will be to move the build logic from ./hooks/build script to _utils.sh and that will be it. |
Codecov Report
@@ Coverage Diff @@
## master #7433 +/- ##
==========================================
+ Coverage 86.37% 86.62% +0.25%
==========================================
Files 877 878 +1
Lines 41221 41292 +71
==========================================
+ Hits 35603 35770 +167
+ Misses 5618 5522 -96
Continue to review full report at Codecov.
|
c9dd419
to
2a5a2f8
Compare
And @ashb -> that's the next step to make the breeze scripts simpler/better testable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little bit lost in two-in-one refactor in this PR (moving things to functions, and also renaming some env vars) but looks okay from what I can tell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure this works for pyenv, but at a code level this LGTM
I could not resist the temptation to rename some of the variables and make them shorter. Since they are all internal and done automatically I think doing it while separating out functions might be a good idea. |
2a5a2f8
to
1e2fbf9
Compare
Confirmed it works fr both pyenv and virtualenv. |
279f348
to
84fce4b
Compare
Hey @ashb. Are you ok with how it is ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than one small tidy up.
84fce4b
to
c892ed2
Compare
Done |
(cherry picked from commit 24f9f11)
(cherry picked from commit 24f9f11)
(cherry picked from commit 24f9f11)
(cherry picked from commit 24f9f11)
Issue link: AIRFLOW-6820
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.