-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6830] Add Subject/MessageAttributes to SNS hook and operator #7451
[AIRFLOW-6830] Add Subject/MessageAttributes to SNS hook and operator #7451
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
Codecov Report
@@ Coverage Diff @@
## master #7451 +/- ##
==========================================
- Coverage 86.66% 86.37% -0.29%
==========================================
Files 877 877
Lines 41241 41266 +25
==========================================
- Hits 35742 35645 -97
- Misses 5499 5621 +122
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor issues I overlooked.
Co-Authored-By: Felix Uellendall <[email protected]>
Awesome work, congrats on your first merged pull request! |
@snazzyfox Thank you very much :) 👍 |
Add
subject
andmessage_attributes
as possible parameters forAwsSnsHook
andSnsPublishOperator
. Both defaults to none and are backwards compatible.Issue link: AIRFLOW-6830
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.