[AIRFLOW-6839] even more mypy speed improvements #7460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require_serial:true is better choice than pass_filename: false as it can speed-up mypy for single file changes. Significant gains can be achieved for single file changes and no cache for all other files. This is majority of cases for our users who have pre-commits installed as hooks because most people change only few files and never run check with --all-files When just one file is changed and no cache is built, the difference is drastic: require_serial: true = 4s pass_filenames: false = 13s
feluelle
approved these changes
Feb 19, 2020
potiuk
added a commit
that referenced
this pull request
Feb 19, 2020
Require_serial:true is better choice than pass_filename: false as it can speed-up mypy for single file changes. Significant gains can be achieved for single file changes and no cache for all other files. This is majority of cases for our users who have pre-commits installed as hooks because most people change only few files and never run check with --all-files When just one file is changed and no cache is built, the difference is drastic: require_serial: true = 4s pass_filenames: false = 13s (cherry picked from commit 3089812)
kaxil
pushed a commit
that referenced
this pull request
Feb 21, 2020
Require_serial:true is better choice than pass_filename: false as it can speed-up mypy for single file changes. Significant gains can be achieved for single file changes and no cache for all other files. This is majority of cases for our users who have pre-commits installed as hooks because most people change only few files and never run check with --all-files When just one file is changed and no cache is built, the difference is drastic: require_serial: true = 4s pass_filenames: false = 13s (cherry picked from commit 3089812)
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
Require_serial:true is better choice than pass_filename: false as it can speed-up mypy for single file changes. Significant gains can be achieved for single file changes and no cache for all other files. This is majority of cases for our users who have pre-commits installed as hooks because most people change only few files and never run check with --all-files When just one file is changed and no cache is built, the difference is drastic: require_serial: true = 4s pass_filenames: false = 13s
kaxil
pushed a commit
that referenced
this pull request
Mar 19, 2020
Require_serial:true is better choice than pass_filename: false as it can speed-up mypy for single file changes. Significant gains can be achieved for single file changes and no cache for all other files. This is majority of cases for our users who have pre-commits installed as hooks because most people change only few files and never run check with --all-files When just one file is changed and no cache is built, the difference is drastic: require_serial: true = 4s pass_filenames: false = 13s (cherry picked from commit 3089812)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 19, 2020
Require_serial:true is better choice than pass_filename: false as it can speed-up mypy for single file changes. Significant gains can be achieved for single file changes and no cache for all other files. This is majority of cases for our users who have pre-commits installed as hooks because most people change only few files and never run check with --all-files When just one file is changed and no cache is built, the difference is drastic: require_serial: true = 4s pass_filenames: false = 13s (cherry picked from commit 3089812)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require_serial:true is better choice than pass_filename: false as it can
speed-up mypy for single file changes.
Significant gains can be achieved for single file changes and no cache for all
other files. This is majority of cases for our users who have pre-commits
installed as hooks because most people change only few files and never run
check with --all-files
When just one file is changed and no cache is built, the difference is drastic:
require_serial: true = 4s
pass_filenames: false = 13s
Issue link: AIRFLOW-6839
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.