Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-4453] Make behavior of none_failed consistent with documentation #7464

Merged
merged 8 commits into from
Mar 26, 2020
Merged

[AIRFLOW-4453] Make behavior of none_failed consistent with documentation #7464

merged 8 commits into from
Mar 26, 2020

Commits on Mar 25, 2020

  1. [AIRFLOW-4453] Make behavior of none_failed consistent with documen… 

    …tation

The documentation for the `none_failed` trigger rule
(https://airflow.apache.org/docs/stable/concepts.html#trigger-rules)
describes its behavior as "all parents have not failed (`failed` or
`upstream_failed`) i.e. all parents have succeeded or been skipped."
With that definition in mind, there is no reason that the check for
`none_failed` should ever have to check for skipped upstream tasks or
set the current task to `skipped`. The current behavior causes the rule
to skip if all upstream tasks have skipped, which is more than a little
confusing. This fixes the behavior to be consistent with the documentation.
    @yuqian90
    root authored and yuqian90 committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    683c8b9 View commit details
    Browse the repository at this point in the history

  2. Add note to UPDATING.md about change to none_failed behavior

    @yuqian90
    root authored and yuqian90 committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    51e65e8 View commit details
    Browse the repository at this point in the history

  3. Add test for none_failed trigger rule change

    @yuqian90
    Joel Croteau authored and yuqian90 committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    7489f82 View commit details
    Browse the repository at this point in the history

  4. Fix test_none_failed_tr_skipped

    @yuqian90
    Qian Yu authored and yuqian90 committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    f35f3bb View commit details
    Browse the repository at this point in the history

  5. Add tests and examples for create_branch_join()

    @yuqian90
    Qian Yu authored and yuqian90 committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    f7bdab2 View commit details
    Browse the repository at this point in the history

  6. Rename to create_branch_join_task

    @yuqian90
    yuqian90 committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    f70d643 View commit details
    Browse the repository at this point in the history

  7. Revert changes related to create_branch_join_task()

    @yuqian90
    yuqian90 committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    0b051da View commit details
    Browse the repository at this point in the history

  8. Add NONE_FAILED_OR_SKIPPED trigger_rule

    @yuqian90
    yuqian90 committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    74f565d View commit details
    Browse the repository at this point in the history