-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6885] Delete worker on success #7507
Merged
dimberman
merged 1 commit into
apache:master
from
dimberman:AIRFLOW-6885_delete-worker-on-success
Mar 19, 2020
Merged
[AIRFLOW-6885] Delete worker on success #7507
dimberman
merged 1 commit into
apache:master
from
dimberman:AIRFLOW-6885_delete-worker-on-success
Mar 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:Scheduler
including HA (high availability) scheduler
k8s
labels
Feb 22, 2020
dimberman
force-pushed
the
AIRFLOW-6885_delete-worker-on-success
branch
from
February 22, 2020 18:36
e375b82
to
f38951b
Compare
dimberman
changed the title
Users now have the option to only delete worker pods when they are su…
[AIRFLOW-6885] Delete worker on success
Feb 22, 2020
turbaszek
reviewed
Feb 22, 2020
kaxil
reviewed
Feb 22, 2020
kaxil
reviewed
Feb 22, 2020
kaxil
reviewed
Feb 22, 2020
kaxil
reviewed
Feb 22, 2020
kaxil
reviewed
Feb 22, 2020
kaxil
reviewed
Feb 22, 2020
turbaszek
approved these changes
Feb 23, 2020
kaxil
reviewed
Feb 23, 2020
kaxil
reviewed
Feb 23, 2020
kaxil
reviewed
Feb 23, 2020
kaxil
approved these changes
Feb 23, 2020
ashb
reviewed
Feb 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the feature idea, but what do you think of using a single (existing) config option with possible values True
, False
, and only_on_success
.
This may be a bag idea because of the config API, but might be more user friendly?
dimberman
force-pushed
the
AIRFLOW-6885_delete-worker-on-success
branch
2 times, most recently
from
February 23, 2020 21:02
48899c3
to
ea82908
Compare
Travis failed:
|
dimberman
force-pushed
the
AIRFLOW-6885_delete-worker-on-success
branch
from
March 19, 2020 13:32
ea82908
to
a7c04ce
Compare
Users now have the option to only delete worker pods when they are successful
dimberman
force-pushed
the
AIRFLOW-6885_delete-worker-on-success
branch
from
March 19, 2020 20:21
6752286
to
be002d4
Compare
kaxil
pushed a commit
that referenced
this pull request
Apr 16, 2020
Users now have the option to only delete worker pods when they are successful Co-authored-by: Daniel Imberman <[email protected]>
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Users now have the option to only delete worker pods when they are successful Co-authored-by: Daniel Imberman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users now have the option to only delete worker pods when they are successful
Issue link: AIRFLOW-6885
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.