[AIRFLOW-6838] Add subcommands to Breeze #7515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been originated by @mik-laj - but I completed it with much better help. With this change 'breeze' introduces sub-commands instead of --switches everywhere and its interface is vastly improved. See for yourself in BREEZE.rst. @mik-laj -> Please take a look. Kudos for pushing Breeze in this direction! |
|
@mik-laj (others) I am wondering if we should not also split flags into categories similar to subcommands - but I think this should be a follow-up PR :) . This one is big enough. |
mik-laj
reviewed
Feb 24, 2020
|
Fantastic @mik-laj ! |
ashb
reviewed
Feb 24, 2020
hooks/build
Outdated
|
|
||
| if [[ ${VERBOSE} == "true" ]]; then | ||
| if [[ ${VERBOSE_COMMANDS:="false"} == "true" ]]; then |
There was a problem hiding this comment.
Suggested change
| if [[ ${VERBOSE_COMMANDS:="false"} == "true" ]]; then | |
| if [[ ${VERBOSE_COMMANDS} == "true" ]]; then |
No default needed, we set it two lines up
ashb
reviewed
Feb 24, 2020
ashb
approved these changes
Feb 24, 2020
kaxil
approved these changes
Feb 24, 2020
This change introduces sub-commands in breeze tool. It is much needed as we have many commands now and it was difficult to separate commands from flags. Also --help output was very long and unreadable. With this change help it is much easier to discover what breeze can do for you as well as navigate with it. Co-authored-by: Jarek Potiuk <[email protected]>
mik-laj
approved these changes
Feb 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #7515 +/- ##
==========================================
+ Coverage 86.8% 86.81% +<.01%
==========================================
Files 893 893
Lines 42228 42247 +19
==========================================
+ Hits 36656 36675 +19
Misses 5572 5572
Continue to review full report at Codecov.
|
potiuk
added a commit
that referenced
this pull request
Feb 25, 2020
This change introduces sub-commands in breeze tool. It is much needed as we have many commands now and it was difficult to separate commands from flags. Also --help output was very long and unreadable. With this change help it is much easier to discover what breeze can do for you as well as navigate with it. Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Kamil Breguła <[email protected]>
6 tasks
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
This change introduces sub-commands in breeze tool. It is much needed as we have many commands now and it was difficult to separate commands from flags. Also --help output was very long and unreadable. With this change help it is much easier to discover what breeze can do for you as well as navigate with it. Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Kamil Breguła <[email protected]>
kaxil
pushed a commit
that referenced
this pull request
Mar 19, 2020
This change introduces sub-commands in breeze tool. It is much needed as we have many commands now and it was difficult to separate commands from flags. Also --help output was very long and unreadable. With this change help it is much easier to discover what breeze can do for you as well as navigate with it. Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Kamil Breguła <[email protected]>
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 19, 2020
This change introduces sub-commands in breeze tool. It is much needed as we have many commands now and it was difficult to separate commands from flags. Also --help output was very long and unreadable. With this change help it is much easier to discover what breeze can do for you as well as navigate with it. Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Kamil Breguła <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: AIRFLOW-6838
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.