[AIRFLOW-6943] Fix utf-8 encodeed description in DAG in Python 2 #7567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinja expects either unicode strings or ascii-encoded byte strings and fail if it receives utf8-encoded byte string. In case python file is UTF8-encoded and description contains UTF-8 characters displaying the dags uses Jinja template that fails in such case. This bug workarounds it by attempting to decode the string with utf-8 decoding and produce unicode instead.
ashb
approved these changes
Feb 27, 2020
kaxil
approved these changes
Feb 27, 2020
mik-laj
approved these changes
Feb 27, 2020
kaxil
pushed a commit
that referenced
this pull request
Mar 19, 2020
Jinja expects either unicode strings or ascii-encoded byte strings and fail if it receives utf8-encoded byte string. In case python file is UTF8-encoded and description contains UTF-8 characters displaying the dags uses Jinja template that fails in such case. This bug workarounds it by attempting to decode the string with utf-8 decoding and produce unicode instead.
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 19, 2020
…che#7567) Jinja expects either unicode strings or ascii-encoded byte strings and fail if it receives utf8-encoded byte string. In case python file is UTF8-encoded and description contains UTF-8 characters displaying the dags uses Jinja template that fails in such case. This bug workarounds it by attempting to decode the string with utf-8 decoding and produce unicode instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jinja expects either unicode strings or ascii-encoded byte strings
and fail if it receives utf8-encoded byte string. In case python
file is UTF8-encoded and description contains UTF-8 characters
displaying the dags uses Jinja template that fails in such case.
This bug workarounds it by attempting to decode the string with
utf-8 decoding and produce unicode instead.
Issue link: AIRFLOW-6943
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.