-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6948] Remove ASCII Airflow from version command #7572
[AIRFLOW-6948] Remove ASCII Airflow from version command #7572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine! :)
|
||
|
||
def version(args): | ||
"""Displays Airflow version at the command line""" | ||
print(settings.HEADER + " v" + airflow.__version__) | ||
print(f"{airflow.__version__}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print(f"{airflow.__version__}") | |
print(airflow.__version__) |
Wait a second.. why are we now still using f string if it is only one variable without any extra string attached to it? 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
Codecov Report
@@ Coverage Diff @@
## master #7572 +/- ##
==========================================
- Coverage 86.82% 86.48% -0.35%
==========================================
Files 896 896
Lines 42635 42621 -14
==========================================
- Hits 37017 36859 -158
- Misses 5618 5762 +144
Continue to review full report at Codecov.
|
cherry-picked from 3709ba9
Before:
after:
Issue link: AIRFLOW-6948
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.