-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6949] Respect explicit spark.kubernetes.namespace
conf to SparkSubmitOperator
#7575
Conversation
…SparkSubmitOperator This means the value from the Operator/dag file takes precedence over the connection The previous behaviour was to emit one line from the conf arg, but then a later one from the connection: ``` --conf spark.kubernetes.namespace=airflow \ --conf spark.kubernetes.namespace=default \ ```
Codecov Report
@@ Coverage Diff @@
## master #7575 +/- ##
==========================================
+ Coverage 86.56% 86.56% +<.01%
==========================================
Files 896 896
Lines 42622 42623 +1
==========================================
+ Hits 36896 36897 +1
Misses 5726 5726
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…SparkSubmitOperator (apache#7575) This means the value from the Operator/dag file takes precedence over the connection The previous behaviour was to emit one line from the conf arg, but then a later one from the connection: ``` --conf spark.kubernetes.namespace=airflow \ --conf spark.kubernetes.namespace=default \ ``` (cherry picked from commit b59042b)
Thanks Fokko! I usually use |
…SparkSubmitOperator (apache#7575) This means the value from the Operator/dag file takes precedence over the connection The previous behaviour was to emit one line from the conf arg, but then a later one from the connection: ``` --conf spark.kubernetes.namespace=airflow \ --conf spark.kubernetes.namespace=default \ ```
) cherry-picked from b59042b
This means the value from the Operator/dag file takes precedence over
the connection
The previous behaviour was to emit one line from the conf arg, but then
a later one from the connection:
Example operator from original reporter:
and it produced this (wrong) spark-submit command:
Issue link: AIRFLOW-6949
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.