-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6860] Default ignore_first_depends_on_past to True #7610
Conversation
ref #7490 (comment) |
2ccd70c
to
5fb4f3e
Compare
CI sad with unrelated reason
|
It's weird, it pass in my local breeze env, but failed in Travis both two of my PR. #7593 |
Yeah, sometimes the tests timeouts. I think @mik-laj was investigating it and we think is related to limited resources on CI (memory swap for example). |
@nuclearpinguin Thanks for the clarification, so did it Travis side or ours? |
It looks like Travis quirks - it looks like the same tests start to fail more often and then after some time they continue to work more reliably. It' super-difficult trace (and know whose fault it is) and figure out what's going on. This is not a simple "We" vs. Travis. We already fixed (or workarounded) a number of problems with Travis and we have an outstanding task to migrate to Github Actions but we have other high priority tasks. @zhongjiajie - Maybe you could help with investigating it or migrating to Github Actions (where we believe things will be more stable)? |
@potiuk Like to help, but I don't have much experience in CI/CD. I could see we already have some discuss in dev-list, and does the related AIP is? https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-23+Migrate+out+of+Travis+CI |
Yep. That's the related PR indeed :) |
d760d76
to
d4db2c9
Compare
@potiuk @nuclearpinguin PTAL, thx. |
Since the original change/PR hasn't been included in a release yet, this should be targeted against the same JIRA |
Got it |
d4db2c9
to
2d8c26f
Compare
I use the same JIRA ticket, change PR title and git commit message, and also close this PR original ticket https://issues.apache.org/jira/browse/AIRFLOW-6976 |
@zhongjiajie The reason for targetting this against AIRFLOW-6976 and not a new jira is around release-automation: if we have separate Jiras for a "related" fix then it is possible to miss this change if the first PR was backported. By having two commits target a single jira issue our existing release scripts ( |
I haven't noticed that before, thanks Ash for the clarification |
2d8c26f
to
42da161
Compare
Travis failed due to job name mistake and fix in #7668, I rebase on master on restart the failing test. |
Codecov Report
@@ Coverage Diff @@
## master #7610 +/- ##
==========================================
- Coverage 86.95% 86.67% -0.28%
==========================================
Files 900 900
Lines 43605 43605
==========================================
- Hits 37915 37796 -119
- Misses 5690 5809 +119
Continue to review full report at Codecov.
|
Co-Authored-By: Felix Uellendall <[email protected]>
Fix UPDATING.md |
Thanks everyone |
Issue link: AIRFLOW-6860
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.