Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6987] Avoid creating default connections #7629

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

NBardelot
Copy link
Contributor

@NBardelot NBardelot commented Mar 5, 2020

AIRFLOW-6987

Adds a new load_default_connections in the Core configuration of Airflow, similar to load_examples but aimed at avoiding the creation of default Connections in airflow/utils/db.py.

By default it is retrocompatible:

  • the default behaviour is the old behaviour (True)
  • the old behaviour is also kept in the CI tests and other places were configuration is used

The config is documented as being new in 1.10.10 (the current version being built using master).

See also in the Helm charts project, concerning the stable/airflow chart:

[stable/airflow] allow default connections to be removed
helm/charts#20568 (by @javamonkey79)
helm/charts#21018 (comment) (by @javamonkey79)

[stable/airflow] Add a feature to run extra init scripts in the scheduler after initdb
helm/charts#21047

@NBardelot NBardelot force-pushed the config/load_default_connections branch from db35106 to e95d69a Compare March 5, 2020 14:34
@villasv
Copy link
Contributor

villasv commented Mar 16, 2020

Looking forward to using this! :-)

Looks like the tests failed but it was a timeout. Could someone trigger a new attempt?
Also @NBardelot you need to include the link to the JIRA issue in the PR description.

@NBardelot
Copy link
Contributor Author

/retest

@potiuk
Copy link
Member

potiuk commented Mar 16, 2020

@NBardelot -> next time please do not delete the template content for JIRA issue :). It's there so that you can put checkmarks for all the points there. I updated the description so that it passes "Mergable" check now.

@potiuk potiuk merged commit ae035cd into apache:master Mar 16, 2020
kaxil pushed a commit that referenced this pull request Mar 18, 2020
kaxil pushed a commit that referenced this pull request Mar 19, 2020
kaxil added a commit that referenced this pull request Mar 21, 2020
kaxil pushed a commit that referenced this pull request Mar 22, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants