Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-7002] Get rid of yaml "parser" in bash #7646

Merged
merged 1 commit into from
Mar 7, 2020

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 7, 2020

Mounts in docker compose file is now generated from an env variable

Please check only last commit.


Issue link: AIRFLOW-7002

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@codecov-io
Copy link

codecov-io commented Mar 7, 2020

Codecov Report

Merging #7646 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7646      +/-   ##
==========================================
- Coverage   32.61%   32.24%   -0.37%     
==========================================
  Files         896      896              
  Lines       42796    42796              
==========================================
- Hits        13957    13799     -158     
- Misses      28839    28997     +158
Impacted Files Coverage Δ
airflow/executors/celery_executor.py 29.72% <0%> (-55.41%) ⬇️
airflow/executors/base_executor.py 34.17% <0%> (-31.65%) ⬇️
airflow/utils/timezone.py 68.75% <0%> (-14.59%) ⬇️
airflow/utils/sqlalchemy.py 72.72% <0%> (-9.1%) ⬇️
airflow/__init__.py 84% <0%> (-8%) ⬇️
airflow/settings.py 69.01% <0%> (-6.34%) ⬇️
airflow/models/taskinstance.py 26.14% <0%> (-3.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d18513c...9667cd9. Read the comment docs.

Mounts in docker compose file is now generated from an env variable
@potiuk potiuk force-pushed the AIRFLOw-7002-get-rid-of-yaml branch from 8923d76 to 9667cd9 Compare March 7, 2020 15:23
@potiuk
Copy link
Member Author

potiuk commented Mar 7, 2020

@nuclearpinguin @ashb @mik-laj -> none of us liked the yaml parser in bash. It's gone now. Green - ready to review.

@potiuk potiuk merged commit 680f767 into apache:master Mar 7, 2020
potiuk added a commit that referenced this pull request Mar 7, 2020
Mounts in docker compose file is now generated from an env variable

(cherry picked from commit 680f767)
pgodek pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 12, 2020
Mounts in docker compose file is now generated from an env variable
kaxil pushed a commit that referenced this pull request Mar 19, 2020
Mounts in docker compose file is now generated from an env variable

(cherry picked from commit 680f767)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Mounts in docker compose file is now generated from an env variable

(cherry picked from commit 680f767)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants