-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-7013] Automated check if Breeze image needs to be pulled #7656
[AIRFLOW-7013] Automated check if Breeze image needs to be pulled #7656
Conversation
This one implements automated check if it is worth to pull image rather than build it locally. When the image is changed a lot (for example with buster) it makes very little sense to rebuild the image, it's better to pull it. This change will automatically detect if it is worth to build or pull&build image when you reach the "need rebuild phase". |
745eb60
to
47958ba
Compare
47958ba
to
14afa7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some docs/comments in the PR somewhere about
- what this is doing -- I'm having trouble following the logic; and
- why (your comment in the PR should go in the script somewhere)
14afa7f
to
05bb391
Compare
05bb391
to
115badc
Compare
Codecov Report
@@ Coverage Diff @@
## master #7656 +/- ##
==========================================
- Coverage 86.98% 86.49% -0.49%
==========================================
Files 904 904
Lines 43736 43736
==========================================
- Hits 38045 37831 -214
- Misses 5691 5905 +214
Continue to review full report at Codecov.
|
All should be good now! |
Hey @ashb -> are you OK with those comments ? |
) (cherry picked from commit 6cc9d81)
) (cherry picked from commit 6cc9d81)
…ache#7656) (cherry picked from commit 6cc9d81)
Issue link: AIRFLOW-7013
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.