Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-7013] Automated check if Breeze image needs to be pulled #7656

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 8, 2020


Issue link: AIRFLOW-7013

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk
Copy link
Member Author

potiuk commented Mar 8, 2020

This one implements automated check if it is worth to pull image rather than build it locally. When the image is changed a lot (for example with buster) it makes very little sense to rebuild the image, it's better to pull it.

This change will automatically detect if it is worth to build or pull&build image when you reach the "need rebuild phase".

@potiuk potiuk force-pushed the AIRFLOW-7013-check-if-docker-pull-needed branch 2 times, most recently from 745eb60 to 47958ba Compare March 8, 2020 17:25
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some docs/comments in the PR somewhere about

  1. what this is doing -- I'm having trouble following the logic; and
  2. why (your comment in the PR should go in the script somewhere)

scripts/ci/_utils.sh Outdated Show resolved Hide resolved
@potiuk potiuk force-pushed the AIRFLOW-7013-check-if-docker-pull-needed branch from 14afa7f to 05bb391 Compare March 10, 2020 16:49
@potiuk potiuk force-pushed the AIRFLOW-7013-check-if-docker-pull-needed branch from 05bb391 to 115badc Compare March 10, 2020 19:38
@codecov-io
Copy link

codecov-io commented Mar 10, 2020

Codecov Report

Merging #7656 into master will decrease coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7656      +/-   ##
==========================================
- Coverage   86.98%   86.49%   -0.49%     
==========================================
  Files         904      904              
  Lines       43736    43736              
==========================================
- Hits        38045    37831     -214     
- Misses       5691     5905     +214     
Impacted Files Coverage Δ
...flow/providers/apache/cassandra/hooks/cassandra.py 21.51% <0.00%> (-72.16%) ⬇️
...w/providers/apache/hive/operators/mysql_to_hive.py 35.84% <0.00%> (-64.16%) ⬇️
airflow/providers/postgres/operators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/providers/redis/operators/redis_publish.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/providers/mongo/sensors/mongo.py 53.33% <0.00%> (-46.67%) ⬇️
airflow/providers/mysql/operators/mysql.py 55.00% <0.00%> (-45.00%) ⬇️
airflow/providers/redis/sensors/redis_key.py 61.53% <0.00%> (-38.47%) ⬇️
airflow/executors/celery_executor.py 50.67% <0.00%> (-37.84%) ⬇️
...roviders/google/cloud/operators/postgres_to_gcs.py 52.94% <0.00%> (-32.36%) ⬇️
airflow/providers/postgres/hooks/postgres.py 78.87% <0.00%> (-15.50%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcfc2aa...115badc. Read the comment docs.

@potiuk
Copy link
Member Author

potiuk commented Mar 10, 2020

All should be good now!

@potiuk
Copy link
Member Author

potiuk commented Mar 11, 2020

Hey @ashb -> are you OK with those comments ?

@potiuk potiuk merged commit 6cc9d81 into apache:master Mar 12, 2020
potiuk added a commit that referenced this pull request Mar 12, 2020
kaxil pushed a commit that referenced this pull request Mar 19, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants