Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6997] Fix worker pods initcontainers #7663

Merged

Conversation

krisgeus
Copy link

@krisgeus krisgeus commented Mar 9, 2020

…rom config


Issue link: AIRFLOW-6997

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@codecov-io
Copy link

Codecov Report

Merging #7663 into v1-10-test will decrease coverage by 0.38%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v1-10-test    #7663      +/-   ##
==============================================
- Coverage       81.64%   81.26%   -0.39%     
==============================================
  Files             529      529              
  Lines           36448    36455       +7     
==============================================
- Hits            29759    29624     -135     
- Misses           6689     6831     +142
Impacted Files Coverage Δ
airflow/contrib/kubernetes/worker_configuration.py 96.47% <100%> (+0.05%) ⬆️
airflow/contrib/kubernetes/volume_mount.py 33.33% <0%> (-66.67%) ⬇️
airflow/contrib/kubernetes/volume.py 50% <0%> (-50%) ⬇️
airflow/contrib/kubernetes/pod_launcher.py 45.11% <0%> (-47.37%) ⬇️
airflow/contrib/kubernetes/pod_generator.py 42.5% <0%> (-45%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 56.84% <0%> (-40.01%) ⬇️
airflow/contrib/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
airflow/contrib/kubernetes/pod.py 95.83% <0%> (-4.17%) ⬇️
...etes_request_factory/kubernetes_request_factory.py 99.13% <0%> (-0.87%) ⬇️
airflow/models/taskinstance.py 93.01% <0%> (-0.48%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad9d5f3...6bc1e3c. Read the comment docs.

@kaxil kaxil requested a review from dimberman March 9, 2020 21:13
@potiuk potiuk force-pushed the v1-10-test branch 5 times, most recently from bb1a168 to cd00d0e Compare March 15, 2020 16:54
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimberman Any final thoughts?

@Fokko Fokko changed the title [AIRFLOW-6997] Make sure worker pods initcontainers obtain env vars f… [AIRFLOW-6997] Fix worker pods initcontainers Mar 16, 2020
@dimberman
Copy link
Contributor

@Fokko lgtm!

@Fokko Fokko merged commit ec76d28 into apache:v1-10-test Mar 17, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 17, 2020

Awesome work, congrats on your first merged pull request!

@Fokko
Copy link
Contributor

Fokko commented Mar 17, 2020

Thanks @krisgeus for the PR 👍

kaxil pushed a commit that referenced this pull request Mar 19, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants