Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-7015] Detect Dockerhub repo/user when building on Dockerhub #7673

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 9, 2020


Issue link: AIRFLOW-7015

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk
Copy link
Member Author

potiuk commented Mar 9, 2020

Simpler and restoring building on dockerhub

@codecov-io
Copy link

Codecov Report

Merging #7673 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7673      +/-   ##
==========================================
+ Coverage   86.82%   86.95%   +0.12%     
==========================================
  Files         897      900       +3     
  Lines       42869    43603     +734     
==========================================
+ Hits        37223    37913     +690     
- Misses       5646     5690      +44
Impacted Files Coverage Δ
...irflow/providers/google/cloud/hooks/datacatalog.py 91.74% <0%> (ø)
...ow/providers/google/cloud/operators/datacatalog.py 93.41% <0%> (ø)
...s/google/cloud/example_dags/example_datacatalog.py 100% <0%> (ø)
airflow/__init__.py 100% <0%> (+8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e848d...a675b03. Read the comment docs.

@potiuk potiuk merged commit e2711af into apache:master Mar 10, 2020
potiuk added a commit that referenced this pull request Mar 10, 2020
pgodek pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 12, 2020
kaxil pushed a commit that referenced this pull request Mar 19, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants