Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-7054] Breeze has an option now to reset db at entry #7710

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 13, 2020


Issue link: AIRFLOW-7054

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil
Copy link
Member

kaxil commented Mar 13, 2020

CI Fails with:

/opt/airflow/scripts/ci/in_container/check_environment.sh: line 203: DB_RESET: unbound variable

@potiuk potiuk force-pushed the AIRFLOW-7054-add-resetdb-to-breeze branch from befcdc3 to 3a2a69a Compare March 13, 2020 10:26
@potiuk
Copy link
Member Author

potiuk commented Mar 13, 2020

CI Fails with:

/opt/airflow/scripts/ci/in_container/check_environment.sh: line 203: DB_RESET: unbound variable

Not any more :)

@potiuk potiuk force-pushed the AIRFLOW-7054-add-resetdb-to-breeze branch from 3a2a69a to da82958 Compare March 13, 2020 11:31
@codecov-io
Copy link

codecov-io commented Mar 13, 2020

Codecov Report

Merging #7710 into master will decrease coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7710      +/-   ##
==========================================
- Coverage   86.90%   86.41%   -0.50%     
==========================================
  Files         906      906              
  Lines       43800    43927     +127     
==========================================
- Hits        38065    37958     -107     
- Misses       5735     5969     +234     
Impacted Files Coverage Δ
...flow/providers/apache/cassandra/hooks/cassandra.py 21.51% <0.00%> (-72.16%) ⬇️
airflow/providers/postgres/operators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/providers/redis/operators/redis_publish.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/providers/mongo/sensors/mongo.py 53.33% <0.00%> (-46.67%) ⬇️
airflow/providers/redis/sensors/redis_key.py 61.53% <0.00%> (-38.47%) ⬇️
airflow/executors/celery_executor.py 50.67% <0.00%> (-37.84%) ⬇️
...roviders/google/cloud/operators/postgres_to_gcs.py 52.94% <0.00%> (-32.36%) ⬇️
airflow/providers/amazon/aws/hooks/base_aws.py 59.41% <0.00%> (-17.90%) ⬇️
airflow/providers/postgres/hooks/postgres.py 78.87% <0.00%> (-15.50%) ⬇️
airflow/utils/process_utils.py 73.25% <0.00%> (-12.80%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421e7a2...da82958. Read the comment docs.

@potiuk potiuk force-pushed the AIRFLOW-7054-add-resetdb-to-breeze branch from da82958 to 4ba60f4 Compare March 13, 2020 14:25
@potiuk
Copy link
Member Author

potiuk commented Mar 13, 2020

I forgot to add help explanation. Added now.

@potiuk potiuk merged commit a86924f into apache:master Mar 13, 2020
potiuk added a commit that referenced this pull request Mar 13, 2020
kaxil pushed a commit that referenced this pull request Mar 19, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants