Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-7066] Use sphinx syntax in concepts.rst #7729

Merged
merged 1 commit into from
Mar 15, 2020

Conversation

zhongjiajie
Copy link
Member

@zhongjiajie zhongjiajie commented Mar 15, 2020


Issue link: AIRFLOW-7066

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@zhongjiajie
Copy link
Member Author

@potiuk
Copy link
Member

potiuk commented Mar 15, 2020

Restarted

@zhongjiajie
Copy link
Member Author

zhongjiajie commented Mar 15, 2020

BTW, I have some question could not understand, in my PR #7709, raise pylint error three time, but airflow/www/views.py is in pylint_todo.txt, which mean will not test by pylint, also test folder will not test by pylint. should where the pylint error? (I only change two files)

I test in breeze using pylint airflow/www/views.py and pylint test/www/views.py only airflow/www/views.py have some error hint(but it in pylint_todo.txt)
@potiuk

@codecov-io
Copy link

codecov-io commented Mar 15, 2020

Codecov Report

Merging #7729 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7729   +/-   ##
=======================================
  Coverage   86.93%   86.93%           
=======================================
  Files         915      915           
  Lines       44158    44158           
=======================================
  Hits        38387    38387           
  Misses       5771     5771           
Impacted Files Coverage Δ
...w/example_dags/example_latest_only_with_trigger.py 100.00% <ø> (ø)
airflow/example_dags/example_subdag_operator.py 100.00% <ø> (ø)
airflow/example_dags/subdags/subdag.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271ee64...4eaaba8. Read the comment docs.

@potiuk
Copy link
Member

potiuk commented Mar 15, 2020

BTW, I have some question could not understand, in my PR #7709, raise pylint error three time, but airflow/www/views.py is in pylint_todo.txt, which mean will not test by pylint, also test folder will not test by pylint. should where the pylint error? (I only change two files)

I test in breeze using pylint airflow/www/views.py and pylint test/www/views.py only airflow/www/views.py have some error hint(but it in pylint_todo.txt)
@exploy

It is the test/ that is failing. We have two separate pre-commits - pylint and pylint-test . The test one is failing in the other build and should be fixed there.

@potiuk potiuk merged commit 0740daf into apache:master Mar 15, 2020
@potiuk
Copy link
Member

potiuk commented Mar 15, 2020

Thanks @zhongjiajie !

@zhongjiajie zhongjiajie deleted the doc_use_sphinx_syntax branch March 16, 2020 02:04
@zhongjiajie
Copy link
Member Author

BTW, I have some question could not understand, in my PR #7709, raise pylint error three time, but airflow/www/views.py is in pylint_todo.txt, which mean will not test by pylint, also test folder will not test by pylint. should where the pylint error? (I only change two files)
I test in breeze using pylint airflow/www/views.py and pylint test/www/views.py only airflow/www/views.py have some error hint(but it in pylint_todo.txt)
@exploy

It is the test/ that is failing. We have two separate pre-commits - pylint and pylint-test . The test one is failing in the other build and should be fixed there.

Ok, will take a look to the test, BTW, thanks for merging

@kaxil kaxil added this to the Airflow 1.10.11 milestone Apr 16, 2020
kaxil pushed a commit that referenced this pull request Jun 22, 2020
potiuk pushed a commit that referenced this pull request Jun 29, 2020
@kaxil kaxil added the type:doc label Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants