-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-7067] Pinned version of Apache Airflow #7730
[AIRFLOW-7067] Pinned version of Apache Airflow #7730
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7730 +/- ##
==========================================
+ Coverage 86.88% 86.92% +0.03%
==========================================
Files 924 924
Lines 44674 44792 +118
==========================================
+ Hits 38816 38934 +118
Misses 5858 5858
Continue to review full report at Codecov.
|
c6a3d1a
to
ff4bfcd
Compare
BTW. I am going to simplify it even more - no need to store fixed requirements in setup.py |
54f91ca
to
bfd5d21
Compare
All should be update and much nicer now @ashb ! |
And all green! |
3b96d22
to
61b8f3d
Compare
INSTALL
Outdated
|
||
brew install sqlite mysql postgresql | ||
|
||
# [required] fetch the tarball and untar the source chnge into the directory that was untarred. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# [required] fetch the tarball and untar the source chnge into the directory that was untarred. | |
# [required] fetch the tarball and untar the source, move into the directory that was untarred. |
# You can also install recommended version of the dependencies by using requirements.txt | ||
# as constraint file | ||
|
||
pip install . --constraint requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should I know if I should use requirements or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not have to - it's the recommended version of dependencies. This is just a hint that you can do it. I proposed to have "apache-airflow-pinned" package release separately. with clear purpose in mind "to have repeatable installation"
I agreed having the --constraint and having to know which version to install might be confusing - that was my point in the discussion - but there are different opinions. For now I just want to merge requirements.txt and it's maintenance mechanism so that we avoid further breakage. But the discussion continues here how to approach it:
I invite you to take part in the discussion and propose some solutions/approach. I would really love to have yours (and others) opinions in the thread there.
61b8f3d
to
6a80f5f
Compare
(cherry picked from commit 8c56388)
(cherry picked from commit 8c56388)
(cherry picked from commit 8c56388)
Issue link: AIRFLOW-7067
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.