-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5705] Fix bug in Secrets Backend #7742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kaxil
changed the title
[AIRFLOW-5705] Fix bug in Secrets Backend
[AIRFLOW-5705] Fix bug in Secrets Backend & add test
Mar 17, 2020
kaxil
changed the title
[AIRFLOW-5705] Fix bug in Secrets Backend & add test
[AIRFLOW-5705] Fix bug in Secrets Backend
Mar 17, 2020
mik-laj
approved these changes
Mar 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #7742 +/- ##
==========================================
- Coverage 86.94% 86.18% -0.77%
==========================================
Files 915 915
Lines 44176 44176
==========================================
- Hits 38407 38071 -336
- Misses 5769 6105 +336
Continue to review full report at Codecov.
|
Sorry @kaxil / thanks |
kaxil
added a commit
that referenced
this pull request
Mar 22, 2020
(cherry picked from commit 4ff9d63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #6376 . There were some bugs where the renaming of configs was not applied at all places
Issue link: AIRFLOW-5705
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.
cc @dstandish