Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5705] Fix bugs in AWS SSM Secrets Backend #7745

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 17, 2020

#6376 had some bugs that this PR fixes

  • AwsSsmSecretsBackend.get_conn_uri should return None if parameter does not exist
  • This PR adds error handling if Parameter is not Found
  • Adds tests case and fixes current tests

Issue link: AIRFLOW-5705

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

cc @dstandish

@kaxil kaxil requested review from ashb and potiuk March 17, 2020 10:37
@boring-cyborg boring-cyborg bot added the provider:amazon-aws AWS/Amazon - related issues label Mar 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #7745 into master will decrease coverage by 22.35%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7745       +/-   ##
===========================================
- Coverage   86.94%   64.59%   -22.36%     
===========================================
  Files         915      914        -1     
  Lines       44176    44171        -5     
===========================================
- Hits        38411    28533     -9878     
- Misses       5765    15638     +9873
Impacted Files Coverage Δ
airflow/secrets/__init__.py 94.87% <100%> (-5.13%) ⬇️
airflow/providers/amazon/aws/secrets/ssm.py 94.28% <85.71%> (+27.61%) ⬆️
...low/contrib/operators/wasb_delete_blob_operator.py 0% <0%> (-100%) ⬇️
airflow/contrib/hooks/vertica_hook.py 0% <0%> (-100%) ⬇️
airflow/contrib/sensors/__init__.py 0% <0%> (-100%) ⬇️
airflow/hooks/mssql_hook.py 0% <0%> (-100%) ⬇️
...viders/docker/example_dags/example_docker_swarm.py 0% <0%> (-100%) ⬇️
airflow/hooks/webhdfs_hook.py 0% <0%> (-100%) ⬇️
airflow/contrib/sensors/emr_base_sensor.py 0% <0%> (-100%) ⬇️
...irflow/contrib/operators/slack_webhook_operator.py 0% <0%> (-100%) ⬇️
... and 494 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff9d63...d1b7329. Read the comment docs.

@kaxil kaxil merged commit 2a54512 into apache:master Mar 17, 2020
@kaxil kaxil deleted the fix-ssm-integration branch March 17, 2020 12:42
kaxil added a commit that referenced this pull request Mar 22, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:secrets provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants