-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-7079] Remove redundant code for storing template_fields #7750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that template_fields are now serialized by default ... Then this is perfectly OK
However serialization tests are failing now :) |
Codecov Report
@@ Coverage Diff @@
## master #7750 +/- ##
===========================================
- Coverage 86.96% 64.63% -22.34%
===========================================
Files 915 914 -1
Lines 44188 44185 -3
===========================================
- Hits 38429 28559 -9870
- Misses 5759 15626 +9867
Continue to review full report at Codecov.
|
We don't need the logic in #6715 to store fields used in Extra Operator links as now we store all the template_fields (#7633)
Issue link: AIRFLOW-7079
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.