-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add production image support #7832
Add production image support #7832
Conversation
ff1d713
to
ba1927a
Compare
There is some error in the scripts. bash breeze restart -a 1.10.6 && bash breeze -a 1.10.6 I got following error:
|
will take a look thanks! |
550e8ef
to
91a424e
Compare
f0c94f8
to
7dce17b
Compare
182a141
to
dc4c5a5
Compare
All corrected - please take another look |
dc4c5a5
to
f0ee1c7
Compare
Taking another look now |
f0ee1c7
to
37014a4
Compare
37014a4
to
314f919
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do other minor changes in follow up PRs
🎉 🎉 ! |
@potiuk I can't tell if I need to reload something but I'm not seeing build-image in auto-complete
|
@dimberman run |
@feluelle works! had to run |
|
||
.. code-block:: | ||
|
||
docker build . -f Dockerfile.ci --build-arg PYTHON_BASE_IMAGE="python:3.7-slim-buster" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker build . -f Dockerfile.ci --build-arg PYTHON_BASE_IMAGE="python:3.7-slim-buster" \ | |
docker build . -f Dockerfile.ci --build-arg PYTHON_BASE_IMAGE="python:3.6-slim-buster" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved/.
docker build . --build-arg PYTHON_BASE_IMAGE="python:3.7-slim-buster" \ | ||
--build-arg PYTHON_MAJOR_MINOR_VERSION=3.7 --build-arg COPY_SOURCE=. \ | ||
--build-arg COPY_TARGET=/opt/airflow --build-arg AIRFLOW_SOURCES=/opt/airflow \ | ||
--build-arg CONSTRAINT_REQUIREMENTS=requirements/requirements-python3.7.txt" \ | ||
--build-arg ENTRYPOINT_FILE=entrypoint.sh \ | ||
--build-arg AIRFLOW_INSTALL_SOURCES="apache-airflow" \ | ||
--build-arg AIRFLOW_INSTALL_VERSION="==1.10.10" \ | ||
--build-arg CONSTRAINT_REQUIREMENTS="https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt" | ||
--build-arg ENTRYPOINT_FILE="https://raw.githubusercontent.com/apache/airflow/1.10.10/entrypoint.sh" \ | ||
--build-arg SOURCES_FROM="Dockerfile" \ | ||
--build-arg SOURCES_TO="/Dockerfile" \ | ||
--build-arg WWW_FOLDER="www_rbac" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is sth. wrong.
docker build . --build-arg PYTHON_BASE_IMAGE="python:3.7-slim-buster" \ | |
--build-arg PYTHON_MAJOR_MINOR_VERSION=3.7 --build-arg COPY_SOURCE=. \ | |
--build-arg COPY_TARGET=/opt/airflow --build-arg AIRFLOW_SOURCES=/opt/airflow \ | |
--build-arg CONSTRAINT_REQUIREMENTS=requirements/requirements-python3.7.txt" \ | |
--build-arg ENTRYPOINT_FILE=entrypoint.sh \ | |
--build-arg AIRFLOW_INSTALL_SOURCES="apache-airflow" \ | |
--build-arg AIRFLOW_INSTALL_VERSION="==1.10.10" \ | |
--build-arg CONSTRAINT_REQUIREMENTS="https://raw.githubusercontent.com/apache/airflow/1.10.10/requirements/requirements-python3.7.txt" | |
--build-arg ENTRYPOINT_FILE="https://raw.githubusercontent.com/apache/airflow/1.10.10/entrypoint.sh" \ | |
--build-arg SOURCES_FROM="Dockerfile" \ | |
--build-arg SOURCES_TO="/Dockerfile" \ | |
--build-arg WWW_FOLDER="www_rbac" | |
docker build . | |
--build-arg PYTHON_BASE_IMAGE="python:3.7-slim-buster" \ | |
--build-arg PYTHON_MAJOR_MINOR_VERSION=3.7 \ | |
--build-arg AIRFLOW_INSTALL_SOURCES="apache-airflow" \ | |
--build-arg AIRFLOW_INSTALL_VERSION="==1.10.10" \ | |
--build-arg CONSTRAINT_REQUIREMENTS=requirements/requirements-python3.7.txt" \ | |
--build-arg ENTRYPOINT_FILE=entrypoint.sh \ | |
--build-arg AIRFLOW_SOURCES_FROM="Dockerfile" \ | |
--build-arg AIRFLOW_SOURCES_TO="/Dockerfile" \ | |
--build-arg WWW_FOLDER="www_rbac" |
Like this @potiuk ?
I think it really depend on your setup. simply '. ./breeze-complete' should do. Did you have another directory with airflow somewhere? Tejh setup-autocomplete sets up a symbolic link to breeze-complete and only one can be active at the same time ... It's a bit tricky to get it right if you have more than one breeze command... The command itself will work though (it will use correct definition). I keep the master v1_10_test in sync so most of the auto-complete is good for both (some values like python version are not) and eventually you will get it right next time you get into the shell... Not sure if UPDATING.md is for those dev tools though. |
Issue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.