-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements now depend on python version #7841
Requirements now depend on python version #7841
Conversation
IT turned out that requirements are slightly different for different versions of python (especially in 1.10) so I had to add different version of requirements. At the same time I removed -pinned version. It's not really needed we should be able to easily install airflow now with one command:
|
f834138
to
8800dc3
Compare
BTW. I am going to re-write some parts of it. I came to the conclusion that generating requirements is too big of a hassle for pre-commits (especially that we need them in different versions) so I will do a separate breeze command (and script for those not using Breeze) so that whenever you modify setup.py and new requirements are needed you will be notified via CI rather than pre-commit. I think it's much less impact on the development workflow. Bear with me :). |
8800dc3
to
422bdaf
Compare
@kaxil @ashb @turbaszek @mik-laj @dimberman -> We have much nicer version now. Requirement generation is now checked only as travis build (separately for each python version) rather than pre-commit and you can esily manually generate the requirements with breeze (examples in doc). Also when you modify setup.py in the way that it will require regeneration of the reuqirements, the build in CI will fail, show you with nice, coloured diff what is added and will ask you to run Pls review. That's the last thing to cherry-pick and test prod image in airflow 1.10.10 |
422bdaf
to
c1660bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #7841 +/- ##
===========================================
- Coverage 87.1% 64.72% -22.38%
===========================================
Files 928 927 -1
Lines 45025 44966 -59
===========================================
- Hits 39217 29104 -10113
- Misses 5808 15862 +10054
Continue to review full report at Codecov.
|
9b02bbf
to
a64eb17
Compare
9d3a5eb
to
0f16fe0
Compare
776f33c
to
7a1a25f
Compare
7a1a25f
to
5245398
Compare
OK. fixed separate requirements for different python versions is green in CI @kaxil @mik-laj -> do you want to take a look before I merge (@turbaszek ) ? |
(cherry picked from commit 3fb5f15)
(cherry picked from commit 3fb5f15)
(cherry picked from commit 3fb5f15)
Generate a separate requirements.txt file for each Python Version we support.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.