Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Show task_id in the Graph View tooltip #7859

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 24, 2020

I am not sure how to add a test for this as the Tooltip is generated using jQuery

Before:
image

After:
image

Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested a review from potiuk March 24, 2020 23:58
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 24, 2020
@kaxil kaxil requested review from feluelle and feng-tao March 25, 2020 00:05
@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #7859 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7859      +/-   ##
==========================================
- Coverage   86.97%   86.96%   -0.01%     
==========================================
  Files         927      927              
  Lines       44963    44963              
==========================================
- Hits        39108    39104       -4     
- Misses       5855     5859       +4     
Impacted Files Coverage Δ
airflow/providers/postgres/hooks/postgres.py 93.05% <0.00%> (-1.39%) ⬇️
airflow/jobs/scheduler_job.py 90.44% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1982c3f...e68ed0c. Read the comment docs.

@kaxil kaxil requested a review from turbaszek March 25, 2020 13:36
@kaxil kaxil merged commit f7229e5 into apache:master Mar 25, 2020
@kaxil kaxil deleted the fix-taskid branch March 25, 2020 14:29
@ashb ashb added this to the Airflow 1.10.10 milestone Mar 26, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
@kaxil kaxil added kind:bug This is a clearly a bug and removed kind:bug This is a clearly a bug labels Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants