Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6399] Serialization: DAG access_control field should be decorated field in DAG serialization #7879

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

lsimoneau
Copy link
Contributor

@lsimoneau lsimoneau commented Mar 25, 2020

This is a modification of #7374 to fix a failing test caused by inconsistent ordering between the serialized DAG and the ground truth DAG.

The _access_control field needs to be defined as a decorated field so the field can be serialized/deserialized incorrectly.


Issue link: AIRFLOW-6399

Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 25, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://apache-airflow-slack.herokuapp.com/

@mik-laj mik-laj requested a review from kaxil March 26, 2020 00:01
…rated field in DAG serialization

Co-authored by: Louis Simoneau <[email protected]>
@lsimoneau
Copy link
Contributor Author

Seems like one of the builds timed out on a CLI test? The tests run green in Breeze on my machine so might just need a bump?

@potiuk
Copy link
Member

potiuk commented Mar 26, 2020

Yeah. Travis got wuiyr unstable those days. I restarted it.

@kaxil kaxil merged commit 2d0db94 into apache:master Mar 26, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 26, 2020

Awesome work, congrats on your first merged pull request!

@kaxil
Copy link
Member

kaxil commented Mar 26, 2020

Thanks @lsimoneau and @codenamelxl

@lsimoneau
Copy link
Contributor Author

@kaxil thanks for that. Can I ask if you expect this to be released in a version before 2.0? We rely on serialisation for some of our cluster monitoring, and are trying to roll out RBAC now but this is a blocker. Otherwise we may try building off a fork for now, but wanted to check with you if there were more bugfix releases coming before 2.0.

@kaxil
Copy link
Member

kaxil commented Mar 26, 2020

@kaxil thanks for that. Can I ask if you expect this to be released in a version before 2.0? We rely on serialisation for some of our cluster monitoring, and are trying to roll out RBAC now but this is a blocker. Otherwise we may try building off a fork for now, but wanted to check with you if there were more bugfix releases coming before 2.0.

Yes this will be included in Airflow 1.10.10 which is expected to be released by early to mid-April (next Month)

kaxil pushed a commit that referenced this pull request Mar 27, 2020
…rated field in DAG serialization (#7879)

Co-authored by: Louis Simoneau <[email protected]>
Co-authored-by: Long Le Xich <[email protected]>

(cherry picked from commit 2d0db94)
kaxil pushed a commit that referenced this pull request Mar 27, 2020
…rated field in DAG serialization (#7879)

Co-authored by: Louis Simoneau <[email protected]>
Co-authored-by: Long Le Xich <[email protected]>

(cherry picked from commit 2d0db94)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
…rated field in DAG serialization (apache#7879)

Co-authored by: Louis Simoneau <[email protected]>
Co-authored-by: Long Le Xich <[email protected]>

(cherry picked from commit 2d0db94)
kaxil pushed a commit that referenced this pull request Mar 30, 2020
…rated field in DAG serialization (#7879)

Co-authored by: Louis Simoneau <[email protected]>
Co-authored-by: Long Le Xich <[email protected]>

(cherry picked from commit 2d0db94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants