-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinning max pandas version to 2.0 (lesser than) to allow pandas 1.0. #7954
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
Please rebase to latest master to fix a problem that I've fixed yesterday. Also just yesterday we've merged a change that will help with managing requirements. It's best if you use Breeze to run See a brand new chapter (and the following ones) in the Contributing guide about it. https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#airflow-dependencies BTW. After rebasing to the latest master you will get a failing "generate requirements" build in case you do not run it and those instructions will be printed in the log of failing build. |
I forked from master this morning (a couple hours ago), I think I'm up to date. Regarding the generation of the requirements files: everything seems to run fine, I get that for example:
But I can't find the requirement file, neither in |
Codecov Report
@@ Coverage Diff @@
## master #7954 +/- ##
==========================================
- Coverage 87.16% 86.90% -0.26%
==========================================
Files 931 932 +1
Lines 45173 45187 +14
==========================================
- Hits 39375 39270 -105
- Misses 5798 5917 +119
Continue to review full report at Codecov.
|
Hello @JPFrancoia -> it looks good but I would like to wait until we merge #7980 . Then I will ask you to rebase it on top of the latest master. What happened in the current case (if you look closely) was that even if you added <2.0 exclusion, Pandas were not upgraded. This is exactly what #7980 is addressing. When you rebase, you will have to run generate-requirements again (this time panda should get bumped to 2.0 for both python versions) and you should re-push the change. Then we will actually test if Pandas 1.0 is OK. |
Hello @JPFrancoia -> it's merged, so you can rebase now. |
Ah, I understand now. Ok, I rebased and regenerated the requirements files. Let's see what happens. |
Nothing broke \o/ |
Awesome work, congrats on your first merged pull request! |
Cool! |
Thanks for your guidance @potiuk . |
Hey thanks for this PR great to be able to have pandas > 1.0! Can I ask when this will make its way into a release? |
1.10.11 will contain this PR |
…pache#7954) (cherry picked from commit 1428c0f)
Issue link: #7905
Currently on master, pandas is pinned to < 1.0.0 in Airflow's dependencies. Version 1.0 was released in October 31, 2019. Lots of projects are starting to migrate to pandas 1.0 and it will gradually become more and more difficult to solve conflicts between their dependencies and Airflow's dependencies.
This PR increases the max version of pandas to
2.0
, which will allow installing pandas 1.0. The minimum pandas version stays unchanged so all existing projects with pandas version pinned to1.0
shouldn't be impacted.My commit passed the pre-commits. I installed (or tried to) installed as much dependencies as possible in the
all
extra (in a local virtualenv), and ran as much unit tests as possible before upgrading pandas. This was my baseline. I then upgraded pandas to 1.0.3 and ran the same tests again and the number of failed tests didn't decrease.I'm sorry I can't give a clearer answer on whether pandas' version will break something, but testing has proven to be difficult: the integration tests are tangled with the unit tests and it's unclear to me which tests should pass or not. Help is appreciated.