Change remove to pop in DebugExecutor #8073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to difference in types between v1.10 and master we have to change set.remove to dict.pop method
boring-cyborg
bot
added
the
area:Scheduler
potiuk
approved these changes
Apr 2, 2020
kaxil
approved these changes
Apr 2, 2020
Codecov Report
@@ Coverage Diff @@
## v1-10-test #8073 +/- ##
==============================================
- Coverage 81.82% 80.72% -1.10%
==============================================
Files 541 541
Lines 37141 37149 +8
==============================================
- Hits 30389 29990 -399
- Misses 6752 7159 +407
Continue to review full report at Codecov.
|
|
Cherry-picked it: cae69fa as there were some conflicts |
|
Thanks @kaxil ! |
kaxil
pushed a commit
that referenced
this pull request
Apr 2, 2020
Due to difference in types between v1.10 and master we have to change set.remove to dict.pop method (cherry picked from commit 7393e3b693f06c81ec2d6fb818600b48146252f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8060
Issue link: https://issues.apache.org/jira/browse/AIRFLOW-6836
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.