Add backticks in IMAGES.rst command description #8075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Apr 2, 2020
kaxil
added a commit
that referenced
this pull request
Apr 2, 2020
(cherry picked from commit f177bb6)
mik-laj
reviewed
Apr 2, 2020
| @@ -34,7 +34,7 @@ The images are named as follows: | |||
|
|
|||
| where: | |||
|
|
|||
| * BRANCH_OR_TAG - branch or tag used when creating the image. Examples: master, v1-10-test, 1.10.10 | |||
| * ``BRANCH_OR_TAG`` - branch or tag used when creating the image. Examples: master, v1-10-test, 1.10.10 | |||
| The ``master`` and ``v1-10-test`` labels are built from branches so they change over time. the 1.10.* and in | |||
| the future ``2.*`` labels are build from git tags and they are "fixed" once built. | |||
| * PYTHON_MAJOR_MINOR_VERSION - version of python used to build the image. Examples: 3.5, 3.7 | |||
There was a problem hiding this comment.
PYTHON_MAJOR_MINOR_VERSION- version of python used to build the image. Examples: 3.5, 3.7
There was a problem hiding this comment.
cc @potiuk can you add this please in your follow up PR
There was a problem hiding this comment.
I already have it :)? I just was totally out-of-steam yesterday :). Will do some follow-ups today :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@potiuk Close this PR if you are already covering it in follow up PR
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.