Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Local and Sequential Executors to Doc #8084

Merged
merged 8 commits into from
Apr 3, 2020

Conversation

xinbinhuang
Copy link
Contributor

@xinbinhuang xinbinhuang commented Apr 3, 2020

Local and Sequential executors are currently missing the Executor section of the doc.


Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added area:docs area:Scheduler including HA (high availability) scheduler labels Apr 3, 2020
@codecov-io
Copy link

codecov-io commented Apr 3, 2020

Codecov Report

Merging #8084 into master will decrease coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8084      +/-   ##
==========================================
- Coverage   87.28%   87.01%   -0.27%     
==========================================
  Files         937      937              
  Lines       45520    45549      +29     
==========================================
- Hits        39731    39634      -97     
- Misses       5789     5915     +126     
Impacted Files Coverage Δ
airflow/executors/local_executor.py 92.48% <100.00%> (ø)
airflow/kubernetes/volume_mount.py 44.44% <0.00%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0.00%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0.00%> (-45.08%) ⬇️
...viders/cncf/kubernetes/operators/kubernetes_pod.py 69.69% <0.00%> (-25.26%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0.00%> (-23.53%) ⬇️
airflow/www/app.py 92.40% <0.00%> (-2.08%) ⬇️
airflow/www/utils.py 80.85% <0.00%> (-1.02%) ⬇️
airflow/www/security.py 91.94% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00d0b1...8cd1205. Read the comment docs.

@xinbinhuang
Copy link
Contributor Author

@mik-laj Thanks for the suggestions and they are fixed. PTAL :)

locally, into just one `LocalExecutor` with multiple modes.
LocalExecutor

.. seealso::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add similar annotations for other executors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@boring-cyborg boring-cyborg bot added the k8s label Apr 3, 2020
@xinbinhuang xinbinhuang requested a review from mik-laj April 3, 2020 07:24
docs/executor/sequential.rst Outdated Show resolved Hide resolved
@xinbinhuang
Copy link
Contributor Author

@kaxil just removed the leading empty lines. Thanks for pointing it out.

@kaxil kaxil merged commit ee12529 into apache:master Apr 3, 2020
@kaxil kaxil added this to the Airflow 1.10.11 milestone Jun 30, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
@kaxil kaxil added the type:doc label Jul 1, 2020
kaxil pushed a commit that referenced this pull request Jul 1, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants