[AIRFLOW-5277] Gantt chart respects per-user the Timezone UI setting #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`new Date()` in javascript was always returning user-local time, so we switch over to using MomentJS to render the ticks. I also had to fix a bug in the `redraw` function here (previously unused, now used when the user selects a different timezone.)
ashb
force-pushed
the
gantt-chart-timezone
branch
from
f202855
to
4cfd3a4
Compare
kaxil
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(click for a slightly larger view)
new Date()in javascript was always returning user-local time, so weswitch over to using MomentJS to render the ticks.
I also had to fix a bug in the
redrawfunction here (previouslyunused, now used when the user selects a different timezone.)
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.